prooftree: refactor#525037
Merged
Merged
Conversation
Move to pkgs/by-name/ Build with default version of OCaml Use finalAttrs pattern Remove unused dependencies
vbgl
added
8.has: clean-up
14 tasks
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
jwiegley
approved these changes
May 28, 2026
nixpkgs-ci
Bot
added
12.approvals: 1
Member
|
thanks a lot! to answer the questions:
gtksourceview is brought in by lablgtk and gtk2 related pkgs are EOL per #410814 this version still doesnt build on darwin $ nix build -L .#prooftree
gtksourceview> Running phase: unpackPhase
gtksourceview> unpacking source archive /nix/store/kd88s6iq082dvf3szvf3czjw6yx0lqgl-gtksourceview-2.10.5.tar.bz2
gtksourceview> source root is gtksourceview-2.10.5
gtksourceview> setting SOURCE_DATE_EPOCH to timestamp 1285667125 of file "gtksourceview-2.10.5/docs/reference/html/up.png"
gtksourceview> Running phase: patchPhase
gtksourceview> applying patch /nix/store/67ddwpmgvk0kfyj3532ciykyfi47wijw-change-igemacintegration-to-gtkosxapplication.patch
gtksourceview> patching file configure.ac
gtksourceview> patching file gtksourceview/Makefile.am
gtksourceview> patching file gtksourceview/gtksourceview-i18n.c
gtksourceview> applying patch /nix/store/v9rq6nwypfavr1g3a2ij0ym7m6wvyy4b-update-to-gtk-mac-integration-2.0-api.patch
gtksourceview> patching file configure.ac
gtksourceview> patching file gtksourceview/gtksourceview-i18n.c
gtksourceview> Running phase: autoreconfPhase
gtksourceview> autoreconf: export WARNINGS=
gtksourceview> autoreconf: Entering directory '.'
gtksourceview> autoreconf: configure.ac: no obvious need to run autopoint
gtksourceview> autoreconf: running: aclocal --force -I m4 ${ACLOCAL_FLAGS}
gtksourceview> configure.ac:102: warning: macro 'AM_GNU_GETTEXT_VERSION' not found in library
gtksourceview> autoreconf: configure.ac: tracing
gtksourceview> autoreconf: running: libtoolize --copy --force
gtksourceview> libtoolize: putting auxiliary files in '.'.
gtksourceview> libtoolize: copying file './ltmain.sh'
gtksourceview> libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
gtksourceview> libtoolize: copying file 'm4/libtool.m4'
gtksourceview> libtoolize: copying file 'm4/ltoptions.m4'
gtksourceview> libtoolize: copying file 'm4/ltsugar.m4'
gtksourceview> libtoolize: copying file 'm4/ltversion.m4'
gtksourceview> libtoolize: copying file 'm4/lt~obsolete.m4'
gtksourceview> autoreconf: running: intltoolize --copy --force
gtksourceview> You should update your 'aclocal.m4' by running aclocal.
gtksourceview> autoreconf: running: gtkdocize --copy
gtksourceview> autoreconf: configure.ac: no need to run autopoint (confirmed)
gtksourceview> autoreconf: running: aclocal --force -I m4 ${ACLOCAL_FLAGS}
gtksourceview> configure.ac:102: warning: macro 'AM_GNU_GETTEXT_VERSION' not found in library
gtksourceview> autoreconf: running: /nix/store/z81cjs7gbr38jza8a9rslfb9x0nyywn1-autoconf-2.73/bin/autoconf --force
gtksourceview> configure.ac:13: warning: The macro 'AC_CONFIG_HEADER' is obsolete.
gtksourceview> configure.ac:13: You should run autoupdate.
gtksourceview> ./lib/autoconf/status.m4:719: AC_CONFIG_HEADER is expanded from...
gtksourceview> configure.ac:13: the top level
gtksourceview> configure.ac:45: warning: The macro 'AC_HELP_STRING' is obsolete.
gtksourceview> configure.ac:45: You should run autoupdate.
gtksourceview> ./lib/autoconf/general.m4:205: AC_HELP_STRING is expanded from...
gtksourceview> aclocal.m4:26: GNOME_COMPILE_WARNINGS is expanded from...
gtksourceview> configure.ac:45: the top level
gtksourceview> configure.ac:45: warning: The macro 'AC_TRY_COMPILE' is obsolete.
gtksourceview> configure.ac:45: You should run autoupdate.
gtksourceview> ./lib/autoconf/general.m4:2903: AC_TRY_COMPILE is expanded from...
gtksourceview> aclocal.m4:26: GNOME_COMPILE_WARNINGS is expanded from...
gtksourceview> configure.ac:45: the top level
gtksourceview> configure.ac:103: warning: The macro 'GLIB_GNU_GETTEXT' is obsolete.
gtksourceview> configure.ac:103: You should run autoupdate.
gtksourceview> aclocal.m4:530: GLIB_GNU_GETTEXT is expanded from...
gtksourceview> aclocal.m4:630: AM_GLIB_GNU_GETTEXT is expanded from...
gtksourceview> configure.ac:103: the top level
gtksourceview> configure.ac:103: warning: The macro 'AC_TRY_LINK' is obsolete.
gtksourceview> configure.ac:103: You should run autoupdate.
gtksourceview> ./lib/autoconf/general.m4:2976: AC_TRY_LINK is expanded from...
gtksourceview> lib/m4sugar/m4sh.m4:689: _AS_IF_ELSE is expanded from...
gtksourceview> lib/m4sugar/m4sh.m4:696: AS_IF is expanded from...
gtksourceview> ./lib/autoconf/general.m4:2305: AC_CACHE_VAL is expanded from...
gtksourceview> ./lib/autoconf/general.m4:2326: AC_CACHE_CHECK is expanded from...
gtksourceview> aclocal.m4:215: GLIB_LC_MESSAGES is expanded from...
gtksourceview> aclocal.m4:530: GLIB_GNU_GETTEXT is expanded from...
gtksourceview> aclocal.m4:630: AM_GLIB_GNU_GETTEXT is expanded from...
gtksourceview> configure.ac:103: the top level
gtksourceview> configure.ac:103: warning: The macro 'AC_TRY_LINK' is obsolete.
gtksourceview> configure.ac:103: You should run autoupdate.
gtksourceview> ./lib/autoconf/general.m4:2976: AC_TRY_LINK is expanded from...
gtksourceview> lib/m4sugar/m4sh.m4:689: _AS_IF_ELSE is expanded from...
gtksourceview> lib/m4sugar/m4sh.m4:696: AS_IF is expanded from...
gtksourceview> ./lib/autoconf/general.m4:2305: AC_CACHE_VAL is expanded from...
gtksourceview> ./lib/autoconf/general.m4:2326: AC_CACHE_CHECK is expanded from...
gtksourceview> lib/m4sugar/m4sh.m4:696: AS_IF is expanded from...
gtksourceview> ./lib/autoconf/headers.m4:90: _AC_CHECK_HEADER_COMPILE is expanded from...
gtksourceview> ./lib/autoconf/headers.m4:57: AC_CHECK_HEADER is expanded from...
gtksourceview> aclocal.m4:314: GLIB_WITH_NLS is expanded from...
gtksourceview> aclocal.m4:530: GLIB_GNU_GETTEXT is expanded from...
gtksourceview> aclocal.m4:630: AM_GLIB_GNU_GETTEXT is expanded from...
gtksourceview> configure.ac:103: the top level
gtksourceview> configure.ac:103: warning: The macro 'AC_TRY_LINK' is obsolete.
gtksourceview> configure.ac:103: You should run autoupdate.
gtksourceview> ./lib/autoconf/general.m4:2976: AC_TRY_LINK is expanded from...
gtksourceview> lib/m4sugar/m4sh.m4:696: AS_IF is expanded from...
gtksourceview> ./lib/autoconf/headers.m4:90: _AC_CHECK_HEADER_COMPILE is expanded from...
gtksourceview> ./lib/autoconf/headers.m4:57: AC_CHECK_HEADER is expanded from...
gtksourceview> aclocal.m4:314: GLIB_WITH_NLS is expanded from...
gtksourceview> aclocal.m4:530: GLIB_GNU_GETTEXT is expanded from...
gtksourceview> aclocal.m4:630: AM_GLIB_GNU_GETTEXT is expanded from...
gtksourceview> configure.ac:103: the top level
gtksourceview> configure.ac:103: warning: The macro 'AC_OUTPUT_COMMANDS' is obsolete.
gtksourceview> configure.ac:103: You should run autoupdate.
gtksourceview> ./lib/autoconf/status.m4:1029: AC_OUTPUT_COMMANDS is expanded from...
gtksourceview> aclocal.m4:314: GLIB_WITH_NLS is expanded from...
gtksourceview> aclocal.m4:530: GLIB_GNU_GETTEXT is expanded from...
gtksourceview> aclocal.m4:630: AM_GLIB_GNU_GETTEXT is expanded from...
gtksourceview> configure.ac:103: the top level
gtksourceview> configure.ac:102: error: undefined or overquoted macro: AM_GNU_GETTEXT_VERSION
gtksourceview> If this token and others are legitimate, please use m4_pattern_allow.
gtksourceview> See the Autoconf documentation.
gtksourceview> autoreconf: error: /nix/store/z81cjs7gbr38jza8a9rslfb9x0nyywn1-autoconf-2.73/bin/autoconf failed with exit status: 1
note: keeping build directory "/nix/var/nix/builds/nix-28740-1638547970"
error: Cannot build '/nix/store/xw5a8rg30jvhrqc7f9cyi4p48rpl5nc6-gtksourceview-2.10.5.drv'.
Reason: builder failed with exit code 1.
Output paths:
/nix/store/pviha4q3r2kmi7xpadbrdsdln7n59qa3-gtksourceview-2.10.5
Last 25 log lines:
> aclocal.m4:314: GLIB_WITH_NLS is expanded from...
> aclocal.m4:530: GLIB_GNU_GETTEXT is expanded from...
> aclocal.m4:630: AM_GLIB_GNU_GETTEXT is expanded from...
> configure.ac:103: the top level
> configure.ac:103: warning: The macro 'AC_TRY_LINK' is obsolete.
> configure.ac:103: You should run autoupdate.
> ./lib/autoconf/general.m4:2976: AC_TRY_LINK is expanded from...
> lib/m4sugar/m4sh.m4:696: AS_IF is expanded from...
> ./lib/autoconf/headers.m4:90: _AC_CHECK_HEADER_COMPILE is expanded from...
> ./lib/autoconf/headers.m4:57: AC_CHECK_HEADER is expanded from...
> aclocal.m4:314: GLIB_WITH_NLS is expanded from...
> aclocal.m4:530: GLIB_GNU_GETTEXT is expanded from...
> aclocal.m4:630: AM_GLIB_GNU_GETTEXT is expanded from...
> configure.ac:103: the top level
> configure.ac:103: warning: The macro 'AC_OUTPUT_COMMANDS' is obsolete.
> configure.ac:103: You should run autoupdate.
> ./lib/autoconf/status.m4:1029: AC_OUTPUT_COMMANDS is expanded from...
> aclocal.m4:314: GLIB_WITH_NLS is expanded from...
> aclocal.m4:530: GLIB_GNU_GETTEXT is expanded from...
> aclocal.m4:630: AM_GLIB_GNU_GETTEXT is expanded from...
> configure.ac:103: the top level
> configure.ac:102: error: undefined or overquoted macro: AM_GNU_GETTEXT_VERSION
> If this token and others are legitimate, please use m4_pattern_allow.
> See the Autoconf documentation.
> autoreconf: error: /nix/store/z81cjs7gbr38jza8a9rslfb9x0nyywn1-autoconf-2.73/bin/autoconf failed with exit status: 1
For full logs, run:
nix log /nix/store/xw5a8rg30jvhrqc7f9cyi4p48rpl5nc6-gtksourceview-2.10.5.drv
error: Cannot build '/nix/store/wbi0i4dnkxs62ir9ff3y0mqmyam4d6jn-ocaml5.4.1-lablgtk-2.18.13.drv'.
Reason: 1 dependency failed.
Output paths:
/nix/store/pm3xxlm30q2mv6jjgj4a4d36fy3sfhh2-ocaml5.4.1-lablgtk-2.18.13
error: Build failed due to failed dependency
error: Cannot build '/nix/store/564mvmrcxffvj92ahyghbnn4y949xglp-prooftree-0.14.drv'.
Reason: 1 dependency failed.
Output paths:
/nix/store/bjjr9yx62xy177kiyfxwnvk0vx9xpixs-prooftree-0.14
error: Build failed due to failed dependencywe still need something like this for it to work: diff --git c/pkgs/desktops/gnome-2/desktop/gtksourceview/default.nix i/pkgs/desktops/gnome-2/desktop/gtksourceview/default.nix
index f7035701133f..917162504325 100644
--- c/pkgs/desktops/gnome-2/desktop/gtksourceview/default.nix
+++ i/pkgs/desktops/gnome-2/desktop/gtksourceview/default.nix
@@ -56,6 +56,7 @@ stdenv.mkDerivation (finalAttrs: {
++ lib.optionals stdenv.hostPlatform.isDarwin [
autoreconfHook
gtk-doc
+ gettext
];
buildInputs = [
@@ -73,6 +74,10 @@ stdenv.mkDerivation (finalAttrs: {
gtk-mac-integration-gtk2
];
+ preAutoreconf = ''
+ export ACLOCAL_PATH="${gettext}/share/gettext/m4:$ACLOCAL_PATH"
+ '';
+
doCheck = false; # requires X11 daemon
passthru.tests.pkg-config = testers.testMetaPkgConfig finalAttrs.finalPackage; |
Member
|
related #522127 |
Member
|
this gtksourceview patch is better #521903 maybe we can directly merge this and wait for that |
Contributor
|
Successfully created backport PR for |
github-actions
Bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move to pkgs/by-name/
Build with default version of OCaml
Use finalAttrs pattern
Remove unused dependencies
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.