Skip to content

alcom: init at 1.8.1#348118

Merged
Scrumplex merged 1 commit into
NixOS:masterfrom
Scrumplex:pkgs/alcom/init
Nov 11, 2024
Merged

alcom: init at 1.8.1#348118
Scrumplex merged 1 commit into
NixOS:masterfrom
Scrumplex:pkgs/alcom/init

Conversation

@Scrumplex

Copy link
Copy Markdown
Member

This is the experimental GUI counterpart of vrc-get (called vrc-get-gui in the repo).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Scrumplex

Copy link
Copy Markdown
Member Author

CC @bddvlpr you might be interested in this ^^

@Scrumplex

Copy link
Copy Markdown
Member Author

nixfmt-check is failing because of deps.nix. This is currently by design and there is no consensus on formatting these: #325053

@bddvlpr

bddvlpr commented Oct 12, 2024

Copy link
Copy Markdown
Member

Interesting, thanks for the PR!

Seems to work as expected with a few minor visual bugs but those might very well be some Wayland moments.
image

@bddvlpr bddvlpr added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 17, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 29, 2024
Comment thread pkgs/by-name/al/alcom/package.nix Outdated
Comment thread pkgs/by-name/al/alcom/package.nix Outdated
@ofborg ofborg Bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 10, 2024
Comment thread pkgs/by-name/al/alcom/package.nix Outdated
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
homepage = "https://github.com/vrc-get/vrc-get";
license = lib.licenses.mit;
maintainers = with lib.maintainers; [ Scrumplex ];
# aarch64-linux: Error failed to build app: Target aarch64-unknown-linux-gnu does not exist. Please run `rustup target list` to see the available targets.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you build this via Nix? It seems odd that the rustup target is not available.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did. I am not quite sure why this error pops up.

@FliegendeWurst FliegendeWurst added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 11, 2024
@Scrumplex Scrumplex merged commit 3f1e726 into NixOS:master Nov 11, 2024
@anatawa12

Copy link
Copy Markdown
Contributor

Hi! author of ALCOM here!

I found that alcom is incorrectly registered with version names of vrc-get.
vrc-get is incremented independently with ALCOM releases.

Could you fix version name?
if possible, could you update them?

Actually latest ALCOM, v0.1.17, is far new than ALCOM at the time vrc-get 1.8.2 is released.

@Scrumplex Scrumplex mentioned this pull request Dec 28, 2024
13 tasks
Scrumplex added a commit to Scrumplex/nixpkgs that referenced this pull request Feb 22, 2025
We were using the wrong tag as pointed out in NixOS#348118 (comment)

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Scrumplex added a commit to Scrumplex/nixpkgs that referenced this pull request Feb 27, 2025
We were using the wrong tag as pointed out in NixOS#348118 (comment)

Co-authored-by: Geist <68447848+AT-Geist@users.noreply.github.com>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants