alcom: 1.8.2 -> 1.0.1

[Scrumplex]

We were using the wrong tag as pointed out in #348118 (comment)

@anatawa12 Our builds in Nixpkgs do not expose the .git directory because of reproducibility issues, which is why I have opted to hijack git rev-parse HEAD to print nixpkgs-<GIT_TAG> instead. That should help you identify user issues on NixOS/Nixpkgs. Feel free to direct people to our bug tracker in case their issues seem very odd.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[anatawa12]

have opted to hijack git rev-parse HEAD to print nixpkgs-<GIT_TAG> instead.

Can you hijack to print actual commit hash used when download instead? the purpose of the commit hash is to determine which version actually user is using.
Version name is shared between multiple commits and if some builds between tag and tag.
If it's not possible it's OK.

---

I will add support for non-git environment build in the future version. I was intended to support such cases in application code but I forgot to support in build script.

[anatawa12]

I fixed unable to build without git in 1.0.0 release

[Scrumplex]

I fixed unable to build without git in 1.0.0 release

Could you point me to the right commit? The build.rs file seems to be unchanged

[anatawa12]

Oh sorry I forgot to push and merge the commit before release. I saw pr list is empty so I thought I already merged the fix.

3f56f8c7127a56b132c78f73d45768c99a747028 is the fix commit and will be included in 1.0.1. If nix has system to patch source code, please apply this fix along with 1.0.0.

[ToasterUwU]

@Scrumplex Did you forget about this, or are you busy atm? Happy to take over if you got something going on rn and have little time for open source.

[Scrumplex]

I just pushed my pending changes. I was stuck at the following issue:

alcom>     Finished `release` profile [optimized] target(s) in 2m 39s
alcom>     Built application at: /build/source/target/x86_64-unknown-linux-gnu/release/ALCOM
alcom>     Bundling ALCOM_1.0.1_amd64.deb (/build/source/target/x86_64-unknown-linux-gnu/release/bundle/deb/ALCOM_1.0.1_amd64.deb)
alcom>     Error failed to bundle project:
alcom>     - Unable to find a bundled project for the updater

[anatawa12]

The error message says no appimage is being built but updater artifacts are requested to built.
I think setting bundle.createUpdaterArtifacts to false with passing -c '{"bundle":{"createUpdaterArtifacts":false}}' to tauri build should help the error

[ToasterUwU]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368786

---

x86_64-linux

✅ 1 package built:

• alcom

[ToasterUwU]

Builds so far, but the issue i hope it would fix is still present. Not sure if thats just a me thing or a common thing, but ALCOM doesnt seem to detect unityhub on its own, and when i press the "Select" button to give it the path by hand, i get this error in the terminal followed by ALCOM crashing.
Is this a packaging issue or a software issue? Im on Plasma 6 in case that matters here.

(ALCOM:56524): GLib-GIO-ERROR **: 16:39:37.867: Settings schema 'org.gtk.Settings.FileChooser' is not installed
Trace/breakpoint trap (core dumped)

[anatawa12]

No ALCOM linux user has reported such a issues so I think it's packaging / sandbox issue.

I googled and I found one article. Is this the same problem? https://discourse.nixos.org/t/which-package-includes-org-gtk-gtk4-settings-filechooser/38063

[anatawa12]

Not finding unity hub is depending on how did you installed unity hub, but basically problem of ALCOM.
ALCOM have some set of hard-coded list of possible unity hub location so it might be just you've installed to location we didn't know.
Could you let us know much on ALCOM issues?

If it's from flatpak, we already have issue and awaiting flathub fix: vrc-get/vrc-get#1332

[ToasterUwU]

The location of UnityHub is /nix/store/... Since i installed it via Nix. I assume there is no logic for that in ALCOM, since its very specifically nix, which doesnt even have a package yet.

If you want me to, im happy to make a issue for auto discovery of unityhub via Nix on the ALCOM side. @anatawa12

Besides that, i will wait for a response from Scrumplex about the potential packaging issue

[anatawa12]

Will nixpkgs or some other popular community registry have unity hub or Is there some unity hub stable path regardless how (which nix script) unity hub package is build?
and will nix generate some wrapper executable (script) that we don't have to handle nix specifically?
If so I'm happy with adding nix installation of unity hub to ALCOM known unity hub list so please file a issue.

[ToasterUwU]

@anatawa12 Not entirely sure i can follow the if conditions perfectly. So let me just explain where it will end up and how a program can find the location. And you tell me if thats viable for the ALCOM side and if so i will make a Issue with all the details needed.

1. Location of a nix package binary is always /nix/store/hashOfPackageHere-nameOfPackageHere-versionOfPackageHere followed by the location of the of the file you want from the perspective of / aka root on a typical system. So in my case with the current version of the unityhub package from here, its /nix/store/nd6blaxdglqamc6z265yj1lxcan6kh4h-unityhub-3.11.0/bin/unityhub
2. Because of the structure, there is no static path in that sense
3. However the binary is included via PATH, so running unityhub from the terminal will run it.
4. I found the path of the binary with whereis unityhub which gave me the path from the first section.
5. At least for what i know, there is no wrapper script that will bring unityhub to a traditional place like /bin/unityhub
6. So from all i know the only way to interact with unityhub is by using the PATH or finding the path via whereis or equivalent logic/tools

[anatawa12]

@ToasterUwU it looks we have to consider manything to decide if support nix installation so please create issue and then I consider can we and how we support nix version of unity hub

[CG-GeisT]

Builds so far, but the issue i hope it would fix is still present. Not sure if thats just a me thing or a common thing, but ALCOM doesnt seem to detect unityhub on its own, and when i press the "Select" button to give it the path by hand, i get this error in the terminal followed by ALCOM crashing. Is this a packaging issue or a software issue? Im on Plasma 6 in case that matters here.

(ALCOM:56524): GLib-GIO-ERROR **: 16:39:37.867: Settings schema 'org.gtk.Settings.FileChooser' is not installed
Trace/breakpoint trap (core dumped)

I also had this issue on plasma 6, fixed it by adding wrapGAppsHook to nativeBuildInputs in package.nix

[anatawa12]

@AT-Geist It looks nothing was updated, did you forgot pushing branch?

[CG-GeisT]

Sorry, I haven't pushed my changes yet. I can do that later tonight when I get off work.

Edit: I made a PR during my break

[CG-GeisT]

@Scrumplex I've submitted a PR to your fork, please let me know if I need to change anything

[ToasterUwU]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368786

---

x86_64-linux

✅ 1 package built:

• alcom

[ToasterUwU]

Works now, have to manually select the location of unityhub, but thats not a packaging issue.

[Scrumplex]

I will merge this as-is for now. I am sure we can improve the package over time.