Skip to content

doc/tauri: stdenv.is* -> stdenv.hostPlatform.is*#355251

Merged
Artturin merged 1 commit into
NixOS:masterfrom
Scrumplex:doc/tauri/fix-stdenv-platform-check
Nov 12, 2024
Merged

doc/tauri: stdenv.is* -> stdenv.hostPlatform.is*#355251
Artturin merged 1 commit into
NixOS:masterfrom
Scrumplex:doc/tauri/fix-stdenv-platform-check

Conversation

@Scrumplex

Copy link
Copy Markdown
Member

Noticed this when writing #348118

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added the 8.has: documentation This PR adds or changes documentation label Nov 11, 2024
@Scrumplex Scrumplex requested a review from getchoo November 11, 2024 18:50
@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 11, 2024

@Artturin Artturin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both should be hostPlatform

@Scrumplex Scrumplex force-pushed the doc/tauri/fix-stdenv-platform-check branch from 714b3d0 to a35855e Compare November 11, 2024 19:21
@Scrumplex

Copy link
Copy Markdown
Member Author

No matter how often I think about it, I will always switch them up :/

@Scrumplex Scrumplex requested a review from Artturin November 11, 2024 19:22
@Scrumplex Scrumplex changed the title doc/tauri: stdenv.is* -> stdenv.buildPlatform.is* doc/tauri: stdenv.is* -> stdenv.hostPlatform.is* Nov 11, 2024
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex force-pushed the doc/tauri/fix-stdenv-platform-check branch from a35855e to 86d9f7e Compare November 11, 2024 19:23
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 11, 2024
@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 12, 2024
@Artturin Artturin merged commit e29fc9e into NixOS:master Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: documentation This PR adds or changes documentation 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants