Skip to content

ci: add gh actions build pipeline#1

Open
rikardoricz wants to merge 2 commits into
mainfrom
ci/exclude-safety-node
Open

ci: add gh actions build pipeline#1
rikardoricz wants to merge 2 commits into
mainfrom
ci/exclude-safety-node

Conversation

@rikardoricz

@rikardoricz rikardoricz commented Apr 21, 2026

Copy link
Copy Markdown
Member

3 submodules currently have empty package.xml.

  • safety_node
  • robot_localization
  • odrive_node

This blocks both the build and rosdep-check jobs. Until the submodule upstream provides a valid manifest, skip the package in CI.

Workarounds tagged as TODO

@rikardoricz rikardoricz self-assigned this Apr 21, 2026
@rikardoricz rikardoricz force-pushed the ci/exclude-safety-node branch from 369eeec to d61dd00 Compare April 21, 2026 07:20
@rikardoricz rikardoricz changed the title ci: exclude safety_node stub and guard test-result step ci: add gh actions build pipeline Apr 21, 2026
These submodules currently have empty package.xml:
- safety_node
- robot_localization
- odrive_node

tagged workarounds as TODO
@rikardoricz rikardoricz force-pushed the ci/exclude-safety-node branch from d61dd00 to 78cdbee Compare April 21, 2026 07:59

@kszpieg kszpieg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now looks good. From my side I would like to pay attention of the version of the actions to have it more up-to-date. Maybe in the future we will move some logic to python scripts.

Comment thread .github/workflows/ci.yml
Comment on lines 21 to 23
- name: Checkout (with submodules)
uses: actions/checkout@v4
with:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the newer version is stable now (v6 probably). We can use it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants