Skip to content

The updated code according to the developer's advice, to fit eukaryotic plastid screening - #272

Merged
wwood merged 12 commits into
wwood:mainfrom
Andyargueasae:main
Jul 27, 2026
Merged

The updated code according to the developer's advice, to fit eukaryotic plastid screening#272
wwood merged 12 commits into
wwood:mainfrom
Andyargueasae:main

Conversation

@Andyargueasae

Copy link
Copy Markdown
Contributor

Hi Ben and singleM team,

After talking with Ben several times I reformed the code of my branch, to change the code mainly in condense.py to solve the issue with:

  1. error in writing information to otu when prokaryotic taxa are considered as off-targets (in my context, which deals with plastid/eukaryotic sequences);
  2. target_domain detection in genus-wise EM that causes zero-division errors.

Now, feel free to review it, and feel free to notify me/deny my pull request.

Cheers
Andy

@Andyargueasae

Copy link
Copy Markdown
Contributor Author

I have fixed the condense.py and the trials using default metapackage and my custom plastid metapackage are successful.

Comment thread .gitignore Outdated
Comment thread singlem/condense.py
@wwood

wwood commented Jul 25, 2026

Copy link
Copy Markdown
Owner

@codex review

@Andyargueasae

Copy link
Copy Markdown
Contributor Author

Resolved the above issues and the trials for both metapackages are now passed.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: a8bd6a40d4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@wwood
wwood merged commit 504ffaf into wwood:main Jul 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants