The updated code according to the developer's advice, to fit eukaryotic plastid screening - #272
Merged
Conversation
…for the singlem bespoke package for plastid markers.
… decoy sequences, replaced with target-domain matching.
…rchaea and eukaryote singleM metapackages
Contributor
Author
|
I have fixed the condense.py and the trials using default metapackage and my custom plastid metapackage are successful. |
wwood
requested changes
Jul 25, 2026
added 2 commits
July 25, 2026 22:27
…ackages by per-spkg inspections
Owner
|
@codex review |
Contributor
Author
|
Resolved the above issues and the trials for both metapackages are now passed. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ben and singleM team,
After talking with Ben several times I reformed the code of my branch, to change the code mainly in condense.py to solve the issue with:
Now, feel free to review it, and feel free to notify me/deny my pull request.
Cheers
Andy