Fix data broker launcher toggle and welcome title clipping#19
Merged
Conversation
Clicking a data broker launcher while the search bar was open closed it on
mouse-DOWN via the bar's outside-click handler, then reopened it on mouse-UP,
so it blinked instead of toggling shut. The bar already special-cases the
minimap button by checking the live mouse focus (a flag alone races this
event), so the launcher now records the display-owned buttons it is clicked
through and that same check covers them. Weak-keyed: a display rebuilding its
bar must not keep dead frames alive.
The What's New and changelog entries now say support was ADDED for data
broker displays -- as written, someone without one read it as a feature to
go looking for inside EasyFind. Reworded in all 11 locales.
Also fixes the welcome title clipping its version ("EasyFind v2.1..."):
that header renders 1.5x larger than the rest but was bounded by the shared
width reserving room for the back arrow and close-X, chrome that sits well
above the centred title. Pre-existing since at least 2.1.3, and worse in
longer locales.
"Instead of the minimap button" read as a replacement. It is additive, so the bullet now says every other way in still works, Auto-Hide included, using each locale's own label for that setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #18, folded into 2.1.4 (the earlier tag and release were withdrawn minutes after publishing and never reached CurseForge, so this stays 2.1.4 rather than becoming a new version).
Fixed
Launcher toggle. Clicking a data broker launcher while the search bar was open closed it on mouse-DOWN via the bar's outside-click handler, then reopened it on mouse-UP, so it blinked instead of toggling shut. The bar already special-cases the minimap button by checking the live mouse focus, because a flag alone races that event. The launcher now records the display-owned buttons it is clicked through, and the same check covers them. Weak-keyed, so a display rebuilding its bar does not keep dead frames alive.
Welcome title clipping. The tutorial's welcome header showed
EasyFind v2.1...with the version cut off. That header renders 1.5x larger than every other header but was bounded by the shared header width, which reserves room for the back arrow and close-X -- chrome that sits well above the centred title. It now reserves only page margins. Pre-existing since at least 2.1.3 and worse in longer locales.Changed
What's New and the changelog now say support was added for data broker displays. As written, someone without such a display read it as a feature to go looking for inside EasyFind. Reworded in all 11 locales.
Verification
luacheck clean across 127 files, all locales compile, locale parity holds at 560 keys across 11 files, every
L[]key used in code is defined.