Add a data broker launcher (issue #17)#18
Merged
Merged
Conversation
Publishes a launcher object so display bars can open EasyFind instead of the minimap button. Left-click toggles the search bar, right-click opens options; the tooltip reuses the existing minimap strings, so no new locale keys. Nothing is bundled and nothing happens when no display is installed.
Body and content gate move together: the gate names the version the popup describes, so bumping without a rewrite re-announces stale content and a rewrite without a bump notifies nobody. The IME and autocomplete bullets shipped in 2.1.3, so they are out; the launcher is the only new thing. Translated in all 11 locales, reusing each one's minimap-button wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a data broker launcher, as requested in #17.
Display bars that host data broker objects can now launch EasyFind, so a minimalist UI does not need the minimap button. Left-click toggles the search bar, right-click opens the options, matching the minimap button exactly. Verified in game with Titan Panel.
Notes
DataObjectCreatedcallback, which is how displays pick up late registrations.Release
Version bumped to 2.1.4 (patch: additive, no behavior change for existing users). Changelog entry added. What's New content rewritten for 2.1.4 in all 11 locales, with the content gate bumped alongside it so the popup announces the launcher rather than 2.1.3's notes.
Verification: luacheck clean across 127 files, all locales compile, locale parity holds at 560 keys across 11 files, and every
L[]key referenced in code is defined. Against the shipped 2.1.3 zip this is 181 files in and 181 out, none added or removed.