Skip to content

Hotfix: revert to AGP 8.7.3#21919

Merged
nbradbury merged 1 commit into
release/25.8.1from
issue/CMM-401-revert-agp
May 28, 2025
Merged

Hotfix: revert to AGP 8.7.3#21919
nbradbury merged 1 commit into
release/25.8.1from
issue/CMM-401-revert-agp

Conversation

@nbradbury

@nbradbury nbradbury commented May 28, 2025

Copy link
Copy Markdown
Contributor

Fixes CMM-401

As discussed on the Google Issue Tracker, updating to AGP 8.8 causes the per-app language preference to be lost. If you change the per-app language setting it is briefly retained, but quickly reverts back to the device's default language.

This was not resolved in either AGP 8.9 or 8.10, so the only option was to revert back to 8.7.3.

To test:

  • Change the app language and verify that it's retained
  • Smoke test the app with GBK enabled and verify that it works as expected
  • Note that you may need to use a Pixel device/emulator to reproduce the original problem

Related Slack discussion: p1748343842443099-slack-C04HB8JU78A

@nbradbury nbradbury changed the base branch from trunk to release/25.8.1 May 28, 2025 17:33
@nbradbury nbradbury requested a review from dcalhoun May 28, 2025 17:33
@dangermattic

dangermattic commented May 28, 2025

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@nbradbury nbradbury marked this pull request as ready for review May 28, 2025 17:35
@sonarqubecloud

Copy link
Copy Markdown

@dcalhoun dcalhoun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes tested well, the lost per-app language no longe occurs. Noting this supersedes #21917. 🚀

@dcalhoun

dcalhoun commented May 28, 2025

Copy link
Copy Markdown
Member

IINM, the failed CI checks are expected due to updating the dependency while not targeting the latest trunk branch.

@nbradbury nbradbury merged commit 35e0869 into release/25.8.1 May 28, 2025
16 of 27 checks passed
@nbradbury nbradbury deleted the issue/CMM-401-revert-agp branch May 28, 2025 17:49
@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21919-5b509d6
Commit5b509d6
Direct Downloadwordpress-prototype-build-pr21919-5b509d6.apk
Note: Google Login is not supported on these builds.

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21919-5b509d6
Commit5b509d6
Direct Downloadjetpack-prototype-build-pr21919-5b509d6.apk
Note: Google Login is not supported on these builds.

oguzkocer pushed a commit that referenced this pull request May 28, 2025
oguzkocer pushed a commit that referenced this pull request May 28, 2025
* Bump version number

* Revert AGP to 8.7.3 (#21919)

---------

Co-authored-by: Nick Bradbury <nbradbury@users.noreply.github.com>
@wzieba wzieba restored the issue/CMM-401-revert-agp branch May 29, 2025 13:16
@wzieba wzieba mentioned this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants