You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
As long as CI passed on this, it is a ✅ from my side, thanks for this Lint "fix" @wzieba ! 🚀
PS: @nbradbury , it would indeed be prudent to test this change before merging.
FYI: An alternative would be to keep AGP + Lint on the same version, but (temporarily) disabling NullSafeMutableLiveData on libs:editor, libs:image-editor and WordPress modules, and then, reverting that after bumping AGP to 8.8.1 or higher. Not to 100% sure which is best, but it does seems that using Lint from 8.8.1 could be safe enough... 🤞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: AINFRA-654
Description
This PR fixes failing lint. The problem is the combination of
androidx.lifecycle:2.9.0andAGP:8.7.3.See: https://issuetracker.google.com/issues/418014548
It goes as follows:
✅ Hotfix: revert to AGP 8.7.3 #21919 passed as it was based on an older
trunk:lifecycle:2.8.7+AGP:8.7.3✅ e.g. a306dba
trunkjust before AGP downgrade passed:lifecycle:2.9.0+AGP:8.8.1❌ f9eb16a current
trunkafter merging AGP downgrade:lifecycle:2.9.0+AGP:8.7.3I propose the solution of temporary upgrading Lint version to
8.8.1, while leaving the rest of the AGP in8.7.3for reasons described in #21919