Skip to content

Use lint from AGP 8.8.1#21925

Merged
wzieba merged 1 commit into
trunkfrom
use_agp_lint_8_8_1
May 29, 2025
Merged

Use lint from AGP 8.8.1#21925
wzieba merged 1 commit into
trunkfrom
use_agp_lint_8_8_1

Conversation

@wzieba

@wzieba wzieba commented May 29, 2025

Copy link
Copy Markdown
Contributor

Closes: AINFRA-654

Description

This PR fixes failing lint. The problem is the combination of androidx.lifecycle:2.9.0 and AGP:8.7.3.

See: https://issuetracker.google.com/issues/418014548

It goes as follows:

  • Hotfix: revert to AGP 8.7.3 #21919 passed as it was based on an older trunk: lifecycle:2.8.7 + AGP:8.7.3

  • ✅ e.g. a306dba trunk just before AGP downgrade passed: lifecycle:2.9.0 + AGP:8.8.1

  • f9eb16a current trunk after merging AGP downgrade: lifecycle:2.9.0 + AGP:8.7.3


I propose the solution of temporary upgrading Lint version to 8.8.1, while leaving the rest of the AGP in 8.7.3 for reasons described in #21919

@wzieba

wzieba commented May 29, 2025

Copy link
Copy Markdown
Contributor Author

@nbradbury Can I ask you to test that language settings still work? The Lint version should not affect the production code, but still just in case 🙏

@wzieba wzieba requested review from ParaskP7 and nbradbury May 29, 2025 13:47
@wzieba wzieba added the Tooling label May 29, 2025
@sonarqubecloud

Copy link
Copy Markdown

@adalpari adalpari left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language settings work for me :)

@ParaskP7 ParaskP7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as CI passed on this, it is a ✅ from my side, thanks for this Lint "fix" @wzieba ! 🚀

PS: @nbradbury , it would indeed be prudent to test this change before merging.


FYI: An alternative would be to keep AGP + Lint on the same version, but (temporarily) disabling NullSafeMutableLiveData on libs:editor, libs:image-editor and WordPress modules, and then, reverting that after bumping AGP to 8.8.1 or higher. Not to 100% sure which is best, but it does seems that using Lint from 8.8.1 could be safe enough... 🤞

@wzieba wzieba added this to the 26.2 milestone May 29, 2025
@wpmobilebot

Copy link
Copy Markdown
Contributor
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21925-f6f8e43
Commitf6f8e43
Direct Downloadwordpress-prototype-build-pr21925-f6f8e43.apk
Note: Google Login is not supported on these builds.

@wpmobilebot

Copy link
Copy Markdown
Contributor
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21925-f6f8e43
Commitf6f8e43
Direct Downloadjetpack-prototype-build-pr21925-f6f8e43.apk
Note: Google Login is not supported on these builds.

@nbradbury

Copy link
Copy Markdown
Contributor

Can I ask you to test that language settings still work?

@wzieba I verified that the language settings still work in this branch.

@wzieba wzieba merged commit 31312d2 into trunk May 29, 2025
30 checks passed
@wzieba wzieba deleted the use_agp_lint_8_8_1 branch May 29, 2025 15:00
@oguzkocer oguzkocer modified the milestones: 26.2, 25.9 Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants