Skip to content

Fix a few TLS compliance issues#10594

Open
kareem-wolfssl wants to merge 9 commits into
wolfSSL:masterfrom
kareem-wolfssl:zd21873
Open

Fix a few TLS compliance issues#10594
kareem-wolfssl wants to merge 9 commits into
wolfSSL:masterfrom
kareem-wolfssl:zd21873

Conversation

@kareem-wolfssl

@kareem-wolfssl kareem-wolfssl commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Description

Partially fixes zd#21873

Testing

Built in tests

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@kareem-wolfssl kareem-wolfssl self-assigned this Jun 4, 2026
Copilot AI review requested due to automatic review settings June 4, 2026 00:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens TLS compliance-related behavior in the core handshake and exporter paths, primarily by enforcing correct timing/validity constraints for keying material export and session ticket usage.

Changes:

  • Refuse wolfSSL_export_keying_material() calls until the handshake has fully completed (per RFC 8446 / RFC 5705 intent).
  • Suppress use of expired stored session tickets (fall back to full handshake instead of attempting resumption).
  • Map BUFFER_E to decode_error in TranslateErrorToAlert().

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/ssl.c Adds a “handshake complete” gate before exporting keying material.
src/internal.c Adds client-side session ticket expiry suppression and extends alert translation for buffer errors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/internal.c Outdated
Comment thread src/ssl.c Outdated
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

gcc-arm-cortex-m3

  • FLASH: .text +8 B (+0.0%, 122,547 B / 262,144 B, total: 47% used)

gcc-arm-cortex-m4-openssl-compat

  • FLASH: .text +64 B (+0.0%, 769,276 B / 1,048,576 B, total: 73% used)

gcc-arm-cortex-m4-rsa-only

  • FLASH: .text +64 B (+0.0%, 325,976 B / 1,048,576 B, total: 31% used)

stm32-sim-stm32h753

@kareem-wolfssl
kareem-wolfssl force-pushed the zd21873 branch 2 times, most recently from 133b754 to 9528e7c Compare June 10, 2026 19:04

@dgarske dgarske left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skoll Code Review

Scan type: reviewOverall recommendation: COMMENT
Findings: 4 total — 3 posted, 1 skipped
2 finding(s) posted as inline comments (see file-level comments below)

Posted findings

  • [Medium] Expired-ticket branch drops SessionTicket extension entirely; client may no longer obtain a fresh ticketsrc/internal.c:31665-31687
  • [Medium] No tests added for the three new compliance behaviorstests/api.c
  • [Low] Redundant dual condition in keying-material handshake-complete gatesrc/ssl.c:4076-4080

Skipped findings

  • [Low] Preprocessor directives indented to code column instead of repo convention

Review generated by Skoll

Comment thread src/internal.c
Comment thread src/ssl.c Outdated

@dgarske dgarske left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See skoll review #10594 (review)

@kareem-wolfssl

Copy link
Copy Markdown
Contributor Author

Retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants