fix: stop continuous config reloads - #101
Open
rzssh wants to merge 1 commit into
Open
Conversation
rzssh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filesystem watcher was dropped when
spawn()returned, disconnecting its event channel before any config edits could be observed.The main loop then treated that disconnection as a change event and reloaded config every poll. This reset transient UI state. For example, theme-picker navigation immediately jumped back,
j/kwould not move the cursor, while actual hot reload never worked.This keeps the watcher alive in its worker thread, treats disconnection as no event, and stops the worker when its receiver closes. Regression tests cover real file changes and disconnected channels.
Tested with full test suite and manually verified that the issue with theme-picker navigation was resolved.