Fix: config hot-reload watcher dropped immediately after spawn() - #114
Open
aquinoonell wants to merge 2 commits into
Open
Fix: config hot-reload watcher dropped immediately after spawn()#114aquinoonell wants to merge 2 commits into
aquinoonell wants to merge 2 commits into
Conversation
Author
|
I found that there's an open issue as well as a pull request fix: stop continuous config reloads - #101 who does the same thing as mines, although mines is more targeted. I found the bug after using the app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #113
Fix: move
watcherinto the background thread (let _watcher = watcher;)so its lifetime matches the thread's, instead of ending the moment
spawn()returns.
Testing: confirmed via
eprintln!instrumentation inreload_configandpick_theme_stepthatreload_configwas firing continuously at startupwith no user interaction, and that
pick_theme_step'scurindex wasalways reading back
0. After the fix,reload_configonly fires on anactual edit to
config.toml, and the theme picker preview steps correctlythrough
j/k.@mikenikles