Skip to content

Clean up focusing in dialog-closedby-start-open.html #58788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ltenmoz wants to merge 1 commit into from
Closed

Clean up focusing in dialog-closedby-start-open.html #58788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions html/semantics/interactive-elements/the-dialog-element/dialog-closedby-start-open.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

<dl>
<dt contenteditable></dt>
<dialog id=test2 open></dialog>
<dialog id=test2></dialog>
</dl>

<script>
Expand All @@ -51,6 +51,8 @@
// the dialog to be closed.
const dialog = document.querySelector('dialog#test2');
const controller = new AbortController();
document.querySelector('dt').focus();
dialog.open = true;
document.querySelector('dl').addEventListener("focusin", () => {
dialog.showModal();
},{signal:controller.signal});
Expand All @@ -59,7 +61,6 @@
dialog.open = false;
await new Promise(resolve => {
document.defaultView.requestIdleCallback(() => {
window.getSelection().addRange(document.createRange());
dialog.close();
resolve();
});
Expand Down
Loading