Clean up focusing in dialog-closedby-start-open.html#58788
Closed
ltenmoz wants to merge 1 commit into
Closed
Conversation
ltenmoz
force-pushed
the
fix-dialog-closedby-start-open
branch
from
93de2e5 to
226b879
Compare
ltenmoz
force-pushed
the
fix-dialog-closedby-start-open
branch
from
226b879 to
f32ff49
Compare
ltenmoz
changed the title
close() instead of open = false in dialog-closedby-start-open.htmldialog-closedby-start-open.html
Contributor
Author
|
hmm actually there is now some problem on chrome canary… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test claims that setting
open = falserestores focus to the previous element but I think it is actually the mysteriously-placedwindow.getSelection().addRange(document.createRange());that's doing that (at least, right now it's passing on Chrome stable even though restoring focus withopen = falseis not implemented there).(Arguably this should be a tentative test since whatwg/html#10124 is not merged but I don't know how strict people are about that…)