Skip to content

Make closeWatcher.requestClose() not require user activation #49681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chromium-wpt-export-bot merged 1 commit into from
Dec 13, 2024
Merged

Make closeWatcher.requestClose() not require user activation #49681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions close-watcher/basic.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

watcher.requestClose();

assert_array_equals(events, ["cancel[cancelable=false]", "close"]);
assert_array_equals(events, ["cancel[cancelable=true]", "close"]);
}, "requestClose() with no user activation");

test(t => {
Expand Down Expand Up @@ -43,10 +43,10 @@
let watcher = createRecordingCloseWatcher(t, events);

watcher.requestClose();
assert_array_equals(events, ["cancel[cancelable=false]", "close"]);
assert_array_equals(events, ["cancel[cancelable=true]", "close"]);

watcher.destroy();
assert_array_equals(events, ["cancel[cancelable=false]", "close"]);
assert_array_equals(events, ["cancel[cancelable=true]", "close"]);
}, "requestClose() then destroy()");

test(t => {
Expand Down
12 changes: 6 additions & 6 deletions close-watcher/inside-event-listeners.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@
watcher.onclose = () => { watcher.destroy(); }

watcher.requestClose();
assert_array_equals(events, ["cancel[cancelable=false]", "close"]);
assert_array_equals(events, ["cancel[cancelable=true]", "close"]);

watcher.requestClose();
assert_array_equals(events, ["cancel[cancelable=false]", "close"], "since it was inactive, no more events fired");
assert_array_equals(events, ["cancel[cancelable=true]", "close"], "since it was inactive, no more events fired");
}, "destroy() inside onclose");

promise_test(async t => {
Expand All @@ -58,10 +58,10 @@
watcher.onclose = () => { watcher.close(); }

watcher.requestClose();
assert_array_equals(events, ["cancel[cancelable=false]", "close"]);
assert_array_equals(events, ["cancel[cancelable=true]", "close"]);

watcher.requestClose();
assert_array_equals(events, ["cancel[cancelable=false]", "close"], "since it was inactive, no more events fired");
assert_array_equals(events, ["cancel[cancelable=true]", "close"], "since it was inactive, no more events fired");
}, "close() inside onclose");

promise_test(async t => {
Expand All @@ -86,9 +86,9 @@
watcher.onclose = () => { watcher.requestClose(); }

watcher.requestClose();
assert_array_equals(events, ["cancel[cancelable=false]", "close"]);
assert_array_equals(events, ["cancel[cancelable=true]", "close"]);

watcher.requestClose();
assert_array_equals(events, ["cancel[cancelable=false]", "close"], "since it was inactive, no more events fired");
assert_array_equals(events, ["cancel[cancelable=true]", "close"], "since it was inactive, no more events fired");
}, "requestClose() inside onclose");
</script>