Make closeWatcher.requestClose() not require user activation#49681
Merged
Conversation
Per the conversation here: openui/open-ui#1128 (comment) There's a desire to ship closeWatcher.requestClose() along with dialog.requestclose() both not requiring user activation. The spec PR has been updated accordingly: whatwg/html#10737 (in this commit: whatwg/html@76619aa) Fixed: 383593252 Change-Id: I8c05e352d8b4964407a1cee36f35372e192e2ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6092173 Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: David Baron <dbaron@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1396007}
wpt-pr-bot
approved these changes
Dec 13, 2024
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the conversation here:
openui/open-ui#1128 (comment)
There's a desire to ship closeWatcher.requestClose() along with
dialog.requestclose() both not requiring user activation.
The spec PR has been updated accordingly:
whatwg/html#10737
(in this commit:
whatwg/html@76619aa)
Fixed: 383593252
Change-Id: I8c05e352d8b4964407a1cee36f35372e192e2ca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6092173
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: David Baron <dbaron@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1396007}