ci: decouple Linux .deb/.rpm publishing from Flatpak#266
Conversation
The Flatpak maker has failed in CI on every release since v1.9.1, and a maker failure aborts the whole 'electron-forge publish' invocation, so no Linux assets shipped in v1.9.2-v1.9.4. Gate MakerFlatpak behind WCPOS_FLATPAK=1 and attempt the Flatpak as a non-blocking make step with debug output enabled, uploading the bundle to the release only on success.
|
Warning Review limit reached
More reviews will be available in 36 minutes and 55 seconds. Learn how PR review limits work. To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: wcpos/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61fdeb0ec0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Fix triage
|
An apt failure resolving flatpak/flatpak-builder/elfutils in the blocking deps step could still fail publish-linux before the .deb/.rpm publish. Only deb/rpm + native-module prerequisites remain blocking.
Fix triage (updated)
|
Fix triageFresh unresolved review-thread inventory:
Excluded threads: none. Validation:
No push was made because the PR branch already contains the required fix at |
|
@coderabbitai review |
Problem
publish-linuxmakes .deb, .rpm, and .flatpak in oneelectron-forge publishinvocation. The Flatpak maker has failed on every run since v1.9.1 ("flatpak-builder failed with status code 1" — runs 27422983531, 27420071978, and the 1.9.2 release), and one maker failure aborts the entire invocation before publish, so no Linux assets shipped in v1.9.2, v1.9.3, or v1.9.4. The release runbook decision: Flatpak must not block desktop releases.A second problem hidden inside the first: Forge swallows flatpak-builder's output, so all we ever saw was the status-code-1 line — the failures were never root-causeable from CI logs.
Changes
forge.config.ts —
MakerFlatpakis now only added tomakerswhenWCPOS_FLATPAK=1. Defaultpublish-appbuilds and publishes .deb/.rpm only.tag-and-release.yml
publish-linux—continue-on-erroron every step): install Flathub runtimes →electron-forge make --targets=@electron-forge/maker-flatpak --skip-packagewithWCPOS_FLATPAK=1andDEBUG='electron-installer-flatpak*'(so the real flatpak-builder error finally lands in the log) → upload the .flatpak to the release viagh release uploadonly on success.::warning+ job-summary "Flatpak deferred" notice when the attempt didn't complete.Validation
actionlintpasses on the workflow.forge.config.tsparse-checked with esbuild; CI lint/typecheck will run the full check.--targets/--skip-packageconfirmed against the Forge docs.Follow-ups (out of scope)
flathub/com.wcpos.main.ymlonce a .deb ships (per runbook).