feat(flathub): finalize Flathub manifest against the v1.9.4 .deb#267
Conversation
- Fill extra-data url/sha256/size from the published v1.9.4 .deb - Fix apply_extra.sh: use bsdtar (binutils ar is not in the Platform runtime) - Bump runtime/base 24.08 -> 25.08 (manifest, forge.config.ts, publish workflow) - Real screenshot (WP.org asset) + 1.9.2-1.9.4 release entries in metainfo - New flathub-validate.yml: flatpak-builder-lint + end-to-end extra-data install
|
Warning Review limit reached
More reviews will be available in 56 minutes and 7 seconds. Learn how PR review limits work. To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: wcpos/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
flatpak-builder-lint rejects --socket=x11 combined with wayland/fallback-x11; fallback-x11 covers X11-only sessions. The appid-url-not-reachable error is wcpos.com bot protection returning 403 to the linter — tolerated with a warning in CI, must be resolved (WAF or linter exception) before submission.
flatpak-builder's internal flatpak install calls need a D-Bus session bus, which headless runners lack.
flatpak-builder --install runs apply_extra inside the org.flatpak.Builder sandbox where nested user namespaces are blocked. Export to a local repo and install from the host instead (the split Flathub CI uses).
…ble window The Xvfb check disproved StartupWMClass=WCPOS: the app's windows report classes 'wcpos' and 'WooCommercePOS', never 'WCPOS'. The check now reports map state + geometry per window and asserts against visible windows only.
1 participant
Summary
With
woocommerce-pos_1.9.4_amd64.debnow published (first Linux asset since 1.9.1, via #266), the Flathub submission assets can be finalized. This PR resolves everyTODOinflathub/and adds a CI workflow that validates the submission the way Flathub's own CI does.Changes
flathub/com.wcpos.main.ymlextra-datanow points at the real v1.9.4 asset with its actualsha256(2b1c74db…) andsize(95721396) — computed from the downloaded artifact. The asset name matches the existingx-checker-dataurl-template, so future releases auto-update.24.08→25.08(BaseAppbranch/25.08verified to exist; 24.08 is approaching EOL and reviewers would flag it).flathub/apply_extra.sh— bugfix: replacedar x+tar xfwithbsdtar. binutilsaris not present in the Freedesktop Platform runtime thatapply_extraruns against at install time (only the Sdk), so the old script would have failed on every user install.bsdtarreads the.deband its zstddata.tardirectly and is the pattern used by other extra-data.debmanifests (e.g.com.google.Chrome). Verified the payload pathusr/lib/woocommerce-pos/against the real v1.9.4.deb.flathub/com.wcpos.main.metainfo.xmlforge.config.ts/tag-and-release.yml— runtime/base/Sdk refs bumped to 25.08 to stay in sync with the manifest..github/workflows/flathub-validate.yml(new) — runs on PRs touchingflathub/**:flatpak-builder-linton manifest + AppStream, then a fullorg.flatpak.Builderbuild and install, which downloads the published.deband runsapply_extra.shend-to-end, then asserts theWooCommercePOSbinary landed in the installed app. This PR itself exercises it.Notes for the Flathub submission (after this merges)
--device=all(needed for raw USB receipt printers/cash drawers) may require a documented exception with Flathub reviewers — watch the lint step output on this PR.StartupWMClass=WCPOSstill needs confirming withxprop WM_CLASSon a running Linux build.flathub/flathub(new-pr flow) with the files fromflathub/, then verify the app via the wcpos.com domain or GitHub org.Validation
actionlint,xmllint, manifest YAML parse,sh -n, and esbuild TS parse all pass locally.Flathub Validateworkflow runs on this PR — its build+install step is the real test.