Skip to content

Require explicit is_strict declarations for ScalarFnVTable #9007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
connortsui20 wants to merge 1 commit into from
Closed

Require explicit is_strict declarations for ScalarFnVTable #9007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions vortex-array/src/scalar_fn/vtable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,13 +229,10 @@ pub trait ScalarFnVTable: 'static + Sized + Clone + Send + Sync {
///
/// Nullary functions are vacuously strict because they have no input values.
///
/// Conservatively defaults to `false` (non-strict).
/// Every implementation must declare its strictness explicitly.
///
/// This method only checks the expression itself, not its children.
fn is_strict(&self, options: &Self::Options) -> bool {
_ = options;
false
}
fn is_strict(&self, options: &Self::Options) -> bool;

/// Returns whether this expression is semantically fallible. Conservatively defaults to
/// `true`.
Expand Down
Loading