bool array slice to support device buffers - #8875
Conversation
Signed-off-by: Onur Satici <onur@spiraldb.com>
Signed-off-by: Onur Satici <onur@spiraldb.com>
Signed-off-by: Onur Satici <onur@spiraldb.com>
e4c78c6 to
1320562
Compare
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Benchmarks: Vortex queries 📖Verdict: No clear signal (medium confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.725x ✅, 2↑ 0↓)
datafusion / parquet (0.725x ✅, 2↑ 0↓)
duckdb / vortex-file-compressed (0.722x ✅, 2↑ 0↓)
duckdb / parquet (0.862x ✅, 2↑ 0↓)
No file size changes detected. |
Merging this PR will improve performance by 25.72%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | copy_nullable[65536] |
1.4 ms | 1 ms | +31.9% |
| ⚡ | Simulation | copy_non_nullable[65536] |
1,094.3 µs | 913.2 µs | +19.83% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing os/bitbuffer-slice (1320562) with develop (6a79bcf)
Footnotes
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Rationale for this change
bool slicing on device buffers currently panic, because we assert host buffers when using slice on BitBuffer
What changes are included in this PR?
extract the slicing bounds check logic from BitBuffer, use it for both the host and the device buffer backed bool arrays