Skip to content

inline(always) on push - #8893

Closed
blaginin wants to merge 1 commit into
developfrom
db/inline-always
Closed

inline(always) on push#8893
blaginin wants to merge 1 commit into
developfrom
db/inline-always

Conversation

@blaginin

Copy link
Copy Markdown
Member

got a -10% regression after #8875

Signed-off-by: blaginin <github@blaginin.me>
@blaginin blaginin self-assigned this Jul 22, 2026
@joseph-isaacs

Copy link
Copy Markdown
Contributor

Please can you detail exactly what you have found?

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Polar Signals Profiling Results

Latest Run

Status Commit Job Attempt Link
🟢 Done d2f8fd0 1 Explore Profiling Data

Powered by Polar Signals Cloud

@github-actions

Copy link
Copy Markdown
Contributor

Benchmarks: Vortex queries 📖

Verdict: No clear signal (low confidence)
Attributed Vortex impact: +4.9%
Engines: DataFusion No clear signal (+6.4%, low confidence) · DuckDB No clear signal (+3.4%, low confidence)
Vortex (geomean): 1.002x ➖
Parquet (geomean): 0.978x ➖
Shifts: Parquet (control) -2.2% · Median polish +0.9%

How to read Verdict and Engines
  • Verdict: Overall PR-level signal after subtracting baseline drift estimated from Parquet control rows. It can be Likely improvement, Likely regression, or No clear signal.
  • Engines: Per-engine attribution. DataFusion is compared against DataFusion/Parquet controls; DuckDB is compared against DuckDB/Parquet controls. This answers whether each engine improved or regressed independently.
  • Confidence: Based on directional consistency, share of rows above the noise floor, and control-run noise.

datafusion / vortex-file-compressed (1.021x ➖, 0↑ 0↓)
name PR d2f8fd0 (ns) base bc443ac (ns) ratio (PR/base)
vortex_q00/datafusion:vortex-file-compressed 9693628 9491372 1.02
vortex_q01/datafusion:vortex-file-compressed 6205465 6085464 1.02
datafusion / parquet (0.959x ➖, 0↑ 0↓)
name PR d2f8fd0 (ns) base bc443ac (ns) ratio (PR/base)
vortex_q00/datafusion:parquet 19888005 20700667 0.96
vortex_q01/datafusion:parquet 4536397 4740504 0.96
duckdb / vortex-file-compressed (1.032x ➖, 0↑ 0↓)
name PR d2f8fd0 (ns) base bc443ac (ns) ratio (PR/base)
vortex_q00/duckdb:vortex-file-compressed 10223789 10061896 1.02
vortex_q01/duckdb:vortex-file-compressed 6273021 5980392 1.05
duckdb / parquet (0.998x ➖, 0↑ 0↓)
name PR d2f8fd0 (ns) base bc443ac (ns) ratio (PR/base)
vortex_q00/duckdb:parquet 23413339 23407345 1.00
vortex_q01/duckdb:parquet 9419737 9458893 1.00

No file size changes detected.

@blaginin blaginin added the changelog/chore A trivial change label Jul 22, 2026
@blaginin blaginin closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants