Skip to content

Simplify benchmark comments #8581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdamGS merged 1 commit into from
Jun 24, 2026
Merged

Simplify benchmark comments #8581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions .github/workflows/sql-benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,14 +675,9 @@ jobs:
python3 scripts/s3-download.py s3://vortex-ci-benchmark-results/data.json.gz data.json.gz --no-sign-request
gzip -d -c data.json.gz > base.json

benchmark_name="${{ matrix.name }}"
if [ "${{ inputs.benchmark_profile }}" != "full" ]; then
benchmark_name="$benchmark_name (${{ inputs.benchmark_profile }})"
fi

echo "# Benchmarks: $benchmark_name" > comment.md
echo "# Benchmarks: ${{ matrix.name }}" > comment.md
echo '' >> comment.md
uv run --no-project scripts/compare-benchmark-jsons.py base.json results.json "$benchmark_name" \
uv run --no-project scripts/compare-benchmark-jsons.py base.json results.json "${{ matrix.name }}" \
>> comment.md
cat comment.md >> "$GITHUB_STEP_SUMMARY"

Expand All @@ -692,9 +687,8 @@ jobs:
with:
file-path: comment.md
# There is exactly one comment per comment-tag. If a comment with this tag already exists,
# this action will *update* the comment instead of posting a new comment. Therefore, each
# unique benchmark configuration must have a unique comment-tag.
comment-tag: bench-pr-comment-${{ matrix.id }}${{ inputs.benchmark_profile == 'base' && '-base' || '' }}
# this action will *update* the comment instead of posting a new comment.
comment-tag: bench-pr-comment-${{ matrix.id }}

- name: Comment PR on failure
if: failure() && inputs.mode == 'pr' && github.event.pull_request.head.repo.fork == false
Expand All @@ -704,7 +698,7 @@ jobs:
# 🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨

Benchmark `${{ matrix.name }}` (${{ inputs.benchmark_profile }}) failed! Check the [workflow run](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}) for details.
comment-tag: bench-pr-comment-${{ matrix.id }}${{ inputs.benchmark_profile == 'base' && '-base' || '' }}
comment-tag: bench-pr-comment-${{ matrix.id }}

- name: Upload Benchmark Results
if: inputs.mode == 'develop'
Expand Down
Loading