Simplify benchmark comments - #8581
Merged
Merged
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
robert3005
approved these changes
Jun 24, 2026
github-actions
Bot
removed
the
action/benchmark-sql
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 0.991x ➖ How to read Verdict and Engines
datafusion / vortex-file-compressed (0.991x ➖, 1↑ 1↓)
No file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.982x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.980x ➖, 0↑ 0↓)
datafusion / parquet (0.978x ➖, 1↑ 0↓)
datafusion / arrow (0.962x ➖, 2↑ 1↓)
duckdb / vortex-file-compressed (0.975x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.976x ➖, 0↑ 0↓)
duckdb / parquet (0.985x ➖, 0↑ 0↓)
duckdb / duckdb (0.977x ➖, 0↑ 0↓)
File Size Changes (10 files changed, -0.0% overall, 6↑ 4↓)
Totals:
|
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.908x ➖, 4↑ 0↓)
datafusion / vortex-compact (0.933x ➖, 1↑ 0↓)
datafusion / parquet (0.922x ➖, 3↑ 0↓)
duckdb / vortex-file-compressed (0.983x ➖, 1↑ 1↓)
duckdb / vortex-compact (0.936x ➖, 1↑ 0↓)
duckdb / parquet (0.942x ➖, 0↑ 0↓)
File Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.022x ➖, 0↑ 2↓)
datafusion / vortex-compact (1.030x ➖, 0↑ 6↓)
datafusion / parquet (1.011x ➖, 2↑ 3↓)
duckdb / vortex-file-compressed (1.025x ➖, 2↑ 9↓)
duckdb / vortex-compact (1.029x ➖, 1↑ 3↓)
duckdb / parquet (1.016x ➖, 1↑ 1↓)
duckdb / duckdb (1.024x ➖, 1↑ 4↓)
File Size Changes (5 files changed, +0.0% overall, 4↑ 1↓)
Totals:
|
AdamGS
added
the
action/benchmark-sql-full
github-actions
Bot
removed
the
action/benchmark-sql-full
Merging this PR will improve performance by 11.9%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | encode_varbin[(1000, 4)] |
157 µs | 139.8 µs | +12.34% |
| ⚡ | Simulation | encode_varbin[(1000, 32)] |
162.5 µs | 144.8 µs | +12.22% |
| ⚡ | Simulation | encode_varbin[(1000, 8)] |
157.3 µs | 140.4 µs | +12.05% |
| ⚡ | Simulation | encode_varbin[(1000, 2)] |
156.1 µs | 140.7 µs | +10.98% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing adamg/simplify-sql-benchmarks-comments (9fedbc1) with develop (e2478aa)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) How to read Verdict and Engines
duckdb / vortex-file-compressed (0.979x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.992x ➖, 0↑ 0↓)
duckdb / parquet (0.983x ➖, 0↑ 0↓)
File Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.352x ❌, 0↑ 4↓)
datafusion / vortex-compact (1.248x ➖, 0↑ 2↓)
datafusion / parquet (1.081x ➖, 0↑ 2↓)
duckdb / vortex-file-compressed (1.085x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.257x ➖, 0↑ 4↓)
duckdb / parquet (1.078x ➖, 0↑ 0↓)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rational for this change
#8465 made the SQL benchmarks comments and titles unnecessarily verbose, I was too excited to merge it to just get a quicker feedback loop.
What changes are included in this PR?
Restores how SQL benchmarks comments are displayed - one per benchmark, regardless of what workflow ran it.
What APIs are changed? Are there any user-facing changes?
N/A