Rewrite SQL queries in Exim config files#285
Draft
rimas-kudelis wants to merge 8 commits into
Draft
Conversation
- Use `INNER JOIN ON` instead of "comma-joins" with `WHERE` conditions - Fix vexim#276: prevent non-members from posting to private groups when they are members of other groups - modify `virtual_dom_groups` query to not assume that usernames and email addresses match
rimas-kudelis
changed the title
rimas-kudelis
force-pushed
the
issue276
branch
from
c495f6e to
468e653
Compare
Contributor
|
Labas Rimai, virtual_dom_groups queries cause error in mysql 8+, 5.7+, etc... |
Contributor
|
If there is a bigger change now, I'd suggest to put all identifiers (table names, field names and others) inside backticks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INNER JOIN ... ONinstead of "comma-joins" withWHEREconditionsvirtual_dom_groupsquery to not assume that usernames and email addresses match