Fix query to check user group membership#273
Merged
Merged
Conversation
This query does not check if the user is a member of the group. Instead it returns the username for each group it belongs to.
Contributor
|
It seems this will be solved by #285 too. Can someone confirm this. The rewrite uses a different approach for the complete query. |
Collaborator
|
Let's be realistic: #285 might not happen anytime soon, or at all. If we have errors in our SQL syntax and PRs which fix those errors, I think we should merge the PRs. I probably haven't merged this in because I'm not using groups and was too lazy to set some up just to test that this PR does what it says it does. |
Collaborator
|
@tavil85, thanks for the patch and sorry for taking so long! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This query does not check if the user is a member of the group. Instead
it returns the username for each group it belongs to.