Implement migrate command - #276
Merged
Merged
Conversation
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
20 tasks
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
prateek-kumar-improving
marked this pull request as ready for review
July 22, 2026 18:02
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
currantw
self-requested a review
July 27, 2026 22:42
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
currantw
reviewed
Jul 28, 2026
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Aryex
requested changes
Jul 28, 2026
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
currantw
reviewed
Jul 29, 2026
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
currantw
reviewed
Jul 29, 2026
currantw
self-requested a review
July 30, 2026 14:48
currantw
reviewed
Jul 30, 2026
currantw
left a comment
Collaborator
There was a problem hiding this comment.
Just one remaining comment about possible duplicate tests
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
currantw
approved these changes
Jul 30, 2026
currantw
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed to 8ce99a9.
Looks good ✅
Thanks @prateek-kumar-improving 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement the MIGRATE command for both standalone and cluster clients. Supports single-key migration (both clients), multi-key migration (standalone only), COPY/REPLACE flags, and AUTH/AUTH2 credentials.
Issue link
This Pull Request is linked to issue: #236
Linked issue: #275
Features / Behaviour Changes
Implementation
Testing
Standalone tests (tests/ValkeyGlideTest.php) added.
Cluster tests (tests/ValkeyGlideClusterTest.php) added.
Build passes with -Werror, lint clean on all modified files.
Checklist
Before submitting the PR make sure the following are checked: