Implement client Pause and Unpause command - #274
Merged
Conversation
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
20 tasks
prateek-kumar-improving
marked this pull request as ready for review
July 22, 2026 05:50
currantw
self-requested a review
July 22, 2026 16:31
Signed-off-by: prateek-kumar-improving <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Aryex
reviewed
Jul 25, 2026
jamesx-improving
left a comment
Collaborator
There was a problem hiding this comment.
Nice, clean reuse of the existing unified-command framework — the C-level implementation mirrors reset / bgSave and I have no correctness or security concerns there. Left a few unverified test-side questions inline that I couldn't confirm without an initialized glide-core submodule; happy to re-review once you've had a look.
Aryex
approved these changes
Jul 28, 2026
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
jamesx-improving
approved these changes
Jul 28, 2026
jamesx-improving
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks for the fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement CLIENT PAUSE and CLIENT UNPAUSE commands for both standalone and cluster clients. CLIENT PAUSE suspends all client commands for a specified timeout, and CLIENT UNPAUSE resumes processing.
Issue link
This Pull Request is linked to issue: #236
Features / Behaviour Changes
Implementation
Testing
Standalone tests (tests/ValkeyGlideTest.php) added.
Cluster tests (tests/ValkeyGlideClusterTest.php) added.
Build passes with -Werror, lint clean on all modified files.
Checklist
Before submitting the PR make sure the following are checked: