Skip to content

fix(mentions): preserve icons in readonly conversations#1314

Draft
jomeswang wants to merge 1 commit into
mainfrom
codex/fix-mention-icon-fallback
Draft

fix(mentions): preserve icons in readonly conversations#1314
jomeswang wants to merge 1 commit into
mainfrom
codex/fix-mention-icon-fallback

Conversation

@jomeswang

Copy link
Copy Markdown
Collaborator

Summary

  • hydrate readonly rich-text mentions through the same trigger provider resolveMention contract used by the composer
  • render shared MentionPill tokens in readonly content with workspace app, issue, session, and file semantics
  • replace failed custom icon images with semantic fallback glyphs in UI System and AgentGUI surfaces
  • keep icon presentation out of serialized mention Markdown

Why

Workspace apps already resolve icon presentation while composing a mention, but app-owned conversation history only retained durable mention identity. The generic readonly renderer did not invoke the provider resolver, so sent messages lost their app icons. Separately, a non-empty but broken icon URL suppressed fallback glyphs in multiple shared surfaces.

Verification

  • pnpm check:changed
  • pnpm check:ui-boundaries
  • UI System tests and typecheck
  • UI rich-text: 94 tests and typecheck
  • AgentGUI: 192 files, 1793 tests and typecheck
  • repository check:full preflight passed; its parallel Go lane hit unrelated timeout and goal-state flakes, and every reported failing Go test passed immediately when rerun individually

Release

Includes a changeset for agent-gui, ui-rich-text, and ui-system.

Signed-off-by: jomeswang <1551403343@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant