Skip to content

feat(mentions): centralize rich text mention resolution#1324

Merged
jomeswang merged 4 commits into
mainfrom
codex/rich-text-mention-service
Jul 17, 2026
Merged

feat(mentions): centralize rich text mention resolution#1324
jomeswang merged 4 commits into
mainfrom
codex/rich-text-mention-service

Conversation

@jomeswang

@jomeswang jomeswang commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a host-scoped RichTextMentionService with exact identity resolution, single-flight caching, bounded TTL/LRU behavior, keyed invalidation, diagnostics, and React adapters
  • extend workspace external contracts with optional at.resolve / at.subscribe, preserving old-host query fallback and enforcing workspace-app host boundaries
  • wire Desktop workspace and standalone roots, AgentGUI Markdown/node views, and the shared MentionPill fallback so app/group-chat/readonly mentions render icons consistently
  • document the durable identity-only Markdown contract and add package boundary protection

Supersedes #1314.

Validation

  • pnpm check:full — 18/18 tasks passed
  • pnpm check:changed — 18/18 lanes passed
  • AgentGUI full suite — 1,796 tests passed
  • Desktop full suite — 1,489 passed, 2 skipped
  • ui-rich-text — 107 tests passed
  • workspace-external-core — 44 tests passed
  • package builds and packed export verification passed
  • three independent review passes completed; all correctness/security blockers resolved

Compatibility

Legacy providers and old workspace-app hosts continue to work. New consumers can register the service once at the host root; presentation metadata remains runtime-only and is not serialized into Markdown.


Open in Devin Review

devin-ai-integration[bot]

This comment was marked as resolved.

@jomeswang
jomeswang force-pushed the codex/rich-text-mention-service branch from df29489 to 630c0ea Compare July 17, 2026 14:11
Signed-off-by: jomeswang <1551403343@qq.com>
Signed-off-by: jomeswang <1551403343@qq.com>
Signed-off-by: jomeswang <1551403343@qq.com>
Signed-off-by: jomeswang <1551403343@qq.com>
@jomeswang
jomeswang force-pushed the codex/rich-text-mention-service branch from 57227d3 to 8b920dd Compare July 17, 2026 14:39
@jomeswang
jomeswang merged commit 851329a into main Jul 17, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant