feat(mentions): centralize rich text mention resolution#1324
Merged
Conversation
jomeswang
force-pushed
the
codex/rich-text-mention-service
branch
from
July 17, 2026 14:11
df29489 to
630c0ea
Compare
Signed-off-by: jomeswang <1551403343@qq.com>
Signed-off-by: jomeswang <1551403343@qq.com>
Signed-off-by: jomeswang <1551403343@qq.com>
Signed-off-by: jomeswang <1551403343@qq.com>
jomeswang
force-pushed
the
codex/rich-text-mention-service
branch
from
July 17, 2026 14:39
57227d3 to
8b920dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RichTextMentionServicewith exact identity resolution, single-flight caching, bounded TTL/LRU behavior, keyed invalidation, diagnostics, and React adaptersat.resolve/at.subscribe, preserving old-host query fallback and enforcing workspace-app host boundariesMentionPillfallback so app/group-chat/readonly mentions render icons consistentlySupersedes #1314.
Validation
pnpm check:full— 18/18 tasks passedpnpm check:changed— 18/18 lanes passedCompatibility
Legacy providers and old workspace-app hosts continue to work. New consumers can register the service once at the host root; presentation metadata remains runtime-only and is not serialized into Markdown.