Make via-in-pad repair opt-in - #1784
Merged
Merged
Conversation
Contributor
Benchmark This PRRun benchmarks by commenting on this PR: Comment Everything after Use Any PR whose title contains |
Member
Author
|
/benchmark-all |
Contributor
Default Benchmark ResultsPrevious main runDataset: dataset01
Previous main run details
Dataset: dataset01
PR run details
Workflow: View run |
Contributor
srj19 ResultsPrevious main runDataset: srj19
Previous main run details
Dataset: srj19
PR run details
Workflow: View run |
Contributor
srj18 ResultsPrevious main runDataset: srj18
Previous main run details
Dataset: srj18
PR run details
Workflow: View run |
Contributor
srj20 ResultsPrevious main runDataset: srj20
Previous main run details
Dataset: srj20
PR run details
Workflow: View run |
Contributor
srj21 ResultsPrevious main runDataset: srj21
Previous main run details
Dataset: srj21
PR run details
Workflow: View run |
Contributor
srj23 ResultsPrevious main runDataset: srj23
Previous main run details
Dataset: srj23
PR run details
Workflow: View run |
Member
Author
|
/usf --ubuntu-latest |
Contributor
📸 Update Snapshots (focused)❌ Snapshot update failed. Focused test files:
Source failure run: https://github.com/tscircuit/tscircuit-autorouter/actions/runs/30394162573 Changed snapshots:
Environment: ubuntu-latest ( 🔗 Workflow: View run |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
/usf |
Contributor
📸 Update Snapshots (focused)✅ Snapshot updates committed to Focused test files:
Source failure run: https://github.com/tscircuit/tscircuit-autorouter/actions/runs/30397250191 Changed snapshots:
Environment: benchmark runner ( 🔗 Workflow: View run |
AnasSarkiz
marked this pull request as ready for review
July 28, 2026 21:47
0hmX
reviewed
Jul 29, 2026
seveibar
approved these changes
Jul 29, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowViaInPadto the autorouter-ownedSimpleRouteJsontypefalsewhen omittedfalse, andtruevaluesScope
This is intentionally limited to the autorouter SRJ type and the Pipeline 7 repair handoff. No
circuit-jsonorhigh-density-repair03changes are needed; repair03 already exposesenableViaInPadLayerMoveswith an off-by-default behavior.The branch was created directly from upstream
mainatb31d5a115e78caca6fb76d7bcbd2eac4e23e29c2.Validation
GitHub CI validates build, formatting, types, and tests. Benchmark runs can be triggered through the repository benchmark bot.
Related