Pass allowViaInPad to autorouter - #2914
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AnasSarkiz
marked this pull request as ready for review
July 29, 2026 06:18
0hmX
approved these changes
Jul 29, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
KrishnaX12
added a commit
to KrishnaX12/core
that referenced
this pull request
Jul 29, 2026
* Pass allowViaInPad to autorouter * Follow SimpleRouteJson option assignment pattern * Remove allowViaInPad snapshot coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tscircuit/capacity-autorouterto0.0.722allowViaInPadoption into local/phased SimpleRouteJson inputsallowViaInPadremains opt-in: when it is omitted, Core passesundefinedand the autorouter keeps via-in-pad routing disabled.Scope
This is intentionally limited to Core wiring. It does not add Circuit JSON fields, casts, temporary dependency pins, snapshots, or Repair03 changes.
Validation
bun test tests/features/autorouter-allow-via-in-pad.test.tsx— passbunx tsc --noEmit— passbun run build— passbun test— new test passes; local full run completed with 1231 passing and 52 unrelated environment-dependent failures (local HTTP fixture ports, blocked model downloads, and unavailable simulation output)Related