fix: declare runtime dependencies (math-utils, calculate-packing, graphics-debug)#150
Open
yasdhf wants to merge 1 commit into
Open
fix: declare runtime dependencies (math-utils, calculate-packing, graphics-debug)#150yasdhf wants to merge 1 commit into
yasdhf wants to merge 1 commit into
Conversation
|
@yasdhf is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
yasdhf
force-pushed
the
fix/declare-runtime-dependencies
branch
from
July 1, 2026 23:51
c733417 to
a6d8479
Compare
Build is tsup-node (no bundling). The shipped dist imports calculate-packing,
graphics-debug and @tscircuit/math-utils while they sat only in devDependencies,
so a clean `bun add @tscircuit/matchpack` + import throws "Cannot find module".
Following the tscircuit dependency-check convention (internal_lib): external
packages -> dependencies, internal @tscircuit/* -> peerDependencies ("*").
So: calculate-packing + graphics-debug -> dependencies; math-utils -> peerDependencies.
yasdhf
force-pushed
the
fix/declare-runtime-dependencies
branch
from
July 1, 2026 23:55
a6d8479 to
da1e8b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clean install can't import the package —
bun add @tscircuit/matchpackthen import throwsCannot find module.Build is
tsup-node(no bundling), but three packages the shippeddistimports were declared only indevDependencies. Real runtime imports inlib/:graphics-debug×12,@tscircuit/math-utils×5,calculate-packing×4.Fix
Per the tscircuit
dependency-checkconvention (internal_lib): external →dependencies, internal@tscircuit/*→peerDependencies("*").calculate-packing,graphics-debug→dependencies@tscircuit/math-utils→peerDependencies("*"), kept pinned indevDependenciesbunx @tscircuit/dependency-checkpasses; format / test / type-check green.Verification
Built and packed; clean install resolves this package's deps. (
calculate-packing@0.0.75has the same defect — fixed in tscircuit/calculate-packing#101 — and the tree bottoms out atcircuit-json, tscircuit/circuit-json#633.) Same class as tscircuit/dsn-converter#514.