fix: declare runtime dependencies (@tscircuit/circuit-json-util, transformation-matrix)#164
Open
yasdhf wants to merge 1 commit into
Open
fix: declare runtime dependencies (@tscircuit/circuit-json-util, transformation-matrix)#164yasdhf wants to merge 1 commit into
yasdhf wants to merge 1 commit into
Conversation
yasdhf
force-pushed
the
fix/declare-runtime-dependencies
branch
from
July 1, 2026 23:50
a926c85 to
c39fbdc
Compare
Build is tsup-node (no bundling). The shipped dist imports transformation-matrix
(undeclared) and @tscircuit/circuit-json-util (devDependencies only), so a clean
install + import throws "Cannot find module".
Per the repo's dependency-check (internal_lib): transformation-matrix (external)
-> dependencies; @tscircuit/circuit-json-util (internal) -> peerDependencies ("*").
`bunx @tscircuit/dependency-check` now passes.
yasdhf
force-pushed
the
fix/declare-runtime-dependencies
branch
from
July 1, 2026 23:55
c39fbdc to
393bdc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clean install can't import the package —
bun add @tscircuit/checksthenimport "@tscircuit/checks"throwsCannot find module '@tscircuit/circuit-json-util'.Build is
tsup-node(no bundling). The shippeddistimports@tscircuit/circuit-json-util(declared only indevDependencies, ×20 inlib/) andtransformation-matrix(not declared, ×1).Fix
Per this repo's
dependency-check(internal_lib): external →dependencies, internal@tscircuit/*→peerDependencies("*").transformation-matrix→dependencies@tscircuit/circuit-json-util→peerDependencies("*"), kept pinned indevDependenciesbunx @tscircuit/dependency-checkpasses; build / format / test / type-check green.Verification
Built (
tsup-node) and packed; clean install resolves. Full end-to-end import also needs thecircuit-jsonroot fix (tscircuit/circuit-json#633). Same class as tscircuit/dsn-converter#514, tscircuit/matchpack#150, tscircuit/calculate-packing#101.