Skip to content

fix: serve zero-byte binary files correctly #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vagdotdev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: serve zero-byte binary files correctly #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion routes/files/download.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default withRouteSpec({
}

const isText = file.text_content !== undefined
if (!isText && file.binary_content_b64) {
if (!isText && file.binary_content_b64 !== undefined) {
const binaryBody = decodeBase64ToUint8Array(file.binary_content_b64)
const responseBody = uint8ArrayToArrayBuffer(binaryBody)
return new Response(responseBody, {
Expand Down
2 changes: 1 addition & 1 deletion routes/files/download/[[...file_path]].ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default withRouteSpec({
}

const isText = file.text_content !== undefined
if (!isText && file.binary_content_b64) {
if (!isText && file.binary_content_b64 !== undefined) {
const binaryBody = decodeBase64ToUint8Array(file.binary_content_b64)
const responseBody = uint8ArrayToArrayBuffer(binaryBody)
return new Response(responseBody, {
Expand Down
2 changes: 1 addition & 1 deletion routes/files/static/[[...file_path]].ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export default withRouteSpec({
}

const mimeType = getMimeType(file.file_path)
if (file.binary_content_b64) {
if (file.binary_content_b64 !== undefined) {
const binaryBody = decodeBase64ToUint8Array(file.binary_content_b64)
const responseBody = uint8ArrayToArrayBuffer(binaryBody)

Expand Down
33 changes: 33 additions & 0 deletions tests/routes/files.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,39 @@ test("binary file operations", async () => {
)
})

test("zero-byte binary files download and serve as binary", async () => {
const { axios, url } = await getTestServer()

await axios.post("/files/upsert", {
file_path: "/empty.bin",
binary_content_b64: "",
})

const queryDownloadRes = await fetch(
`${url}/files/download?file_path=${encodeURIComponent("/empty.bin")}`,
)
expect(queryDownloadRes.status).toBe(200)
expect(await queryDownloadRes.arrayBuffer()).toHaveProperty("byteLength", 0)
expect(queryDownloadRes.headers.get("content-type")).toBe(
"application/octet-stream",
)
expect(queryDownloadRes.headers.get("content-length")).toBe("0")

const pathDownloadRes = await fetch(`${url}/files/download/empty.bin`)
expect(pathDownloadRes.status).toBe(200)
expect(await pathDownloadRes.arrayBuffer()).toHaveProperty("byteLength", 0)
expect(pathDownloadRes.headers.get("content-type")).toBe(
"application/octet-stream",
)
expect(pathDownloadRes.headers.get("content-length")).toBe("0")

const staticRes = await fetch(`${url}/files/static/empty.bin`)
expect(staticRes.status).toBe(200)
expect(await staticRes.arrayBuffer()).toHaveProperty("byteLength", 0)
expect(staticRes.headers.get("content-type")).toBe("application/octet-stream")
expect(staticRes.headers.get("content-length")).toBe("0")
})

test("file download operations", async () => {
const { axios } = await getTestServer()

Expand Down
Loading