Skip to content

fix: serve zero-byte binary files correctly - #135

Open
vagdotdev wants to merge 1 commit into
tscircuit:mainfrom
vagdotdev:bounty/zero-byte-binary-5
Open

fix: serve zero-byte binary files correctly#135
vagdotdev wants to merge 1 commit into
tscircuit:mainfrom
vagdotdev:bounty/zero-byte-binary-5

Conversation

@vagdotdev

Copy link
Copy Markdown

Summary

  • treat binary_content_b64: "" as a valid binary file instead of falling through to the text response path
  • cover query download, path download, and static serving for zero-byte binary files

Validation

  • bun test tests/routes/files.test.ts
  • bun test
  • bunx tsc --noEmit
  • bun run format:check
  • bun run build
  • git diff --check

/claim #5

@vagdotdev

Copy link
Copy Markdown
Author

/claim #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant