Skip to content

fix: restore direct raw EasyEDA JSON input for TSX conversion #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
techmannih wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: restore direct raw EasyEDA JSON input for TSX conversion #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/websafe/convert-to-typescript-component/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { convertEasyEdaJsonToCircuitJson } from "lib/convert-easyeda-json-to-tsc
import {
type BetterEasyEdaJson,
EasyEdaJsonSchema,
type RawEasyEdaJson,
} from "lib/schemas/easy-eda-json-schema"
import { normalizeManufacturerPartNumber } from "lib/utils/normalize-manufacturer-part-number"
import { getEasyEdaCadModelPlacement } from "../get-easyeda-cad-model-placement"
Expand All @@ -23,7 +24,12 @@ const getGeneratedComponentType = (
return "chip"
}

export const convertRawEasyToTsx = async ({ rawEasy }: { rawEasy: any }) => {
type ConvertRawEasyToTsxInput = RawEasyEdaJson | { rawEasy: RawEasyEdaJson }

export const convertRawEasyToTsx = async (input: ConvertRawEasyToTsxInput) => {
// The public API and CLI pass raw EasyEDA JSON directly. Keep accepting the
// temporary wrapped form too so existing callers are not broken.
const rawEasy = "rawEasy" in input ? input.rawEasy : input
const betterEasy = EasyEdaJsonSchema.parse(rawEasy)
const result = await convertBetterEasyToTsx({
betterEasy,
Expand Down
Loading
Loading