fix: restore direct raw EasyEDA JSON input for TSX conversion - #407
Open
techmannih wants to merge 1 commit into
Open
fix: restore direct raw EasyEDA JSON input for TSX conversion#407techmannih wants to merge 1 commit into
techmannih wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
|
@techmannih fix the call site, this is absolutely not the right way to fix this!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue
convertRawEasyToTsxexpected the EasyEDA JSON to be wrapped:However, both the CLI and the documented public API pass raw EasyEDA JSON directly:
Because of this mismatch,
rawEasybecameundefined, and Zod validation failed with:The issue was reproduced while importing the JLCPCB component
C44346038.This was not a problem with
BaseShapeSchemaor the component's footprint data. The BetterEasy JSON and Circuit JSON conversions were already working correctly; only the TSX conversion path was affected.Solution
convertRawEasyToTsx.{ rawEasy }input for backward compatibility.C44346038EasyEDA fixture.The converter now supports both forms:
Impact on Other Components
This fix should not negatively affect other components.
{ rawEasy }remain supported.