Respect routed via layer spans - #2944
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pcb_via.layersfrom each route point'sfrom_layerandto_layerinstead of expanding every via across the full board stackWhy
The fanout solver already emits correct plane drops such as
top -> inner1andtop -> inner2. Core was preserving those endpoint fields but settingpcb_via.layersto every board layer. That made DRC and later routing treat blind plane drops as through-vias, causing false collisions on signal layers beyond the via's physical span.This surfaced in the RK3326 fanout as 15 USB-to-supply-via DRC errors on
inner3even though its 205 supply vias terminate oninner1orinner2.Scope
This is intentionally separate from the fanout plane-inference change in #2929. It changes two production call sites and only the existing expectations that encoded full-stack vias.
Validation
bunx tsc --noEmitbun run buildtop -> inner1ground drops and 51top -> inner2power drops