NAS-140878 / 27.0.0-BETA.1 / Extend error message for full ZFS replication when there are missing datasets#359
Merged
Merged
Conversation
Contributor
Author
|
time 2:00 |
bugclerk
changed the title
yocalebo
approved these changes
Jul 6, 2026
|
This PR has been merged and conversations have been locked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full ZFS replication fails when some of the source datasets with older snapshots are not present on the destination side.
This can happen in case of dataset rename. We do dataset renames when migrating from incus to new containers system, that's the root cause of the reported issue.
I am reluctant to try to replicate dataset renames automatically. We can try parsing
zpool history, but, after all, it's just a text stream without any structure and there is no guarantee it is consistent with the real history.Additionally, we can try matching renamed datasets by snapshots
guids (snapshots guid are the same on the source and destination system). However, this will require retrieving a lot of snapshot metadata on both source and destination systems, and add unnecessary complexity for such a rare case.