Skip to content

NAS-140878 / 26.0.0-RC.1 / Extend error message for full ZFS replication when there are missing datasets (by themylogin)#364

Merged
yocalebo merged 1 commit into
stable/26from
NAS-140878-26.0.0-RC.1
Jul 6, 2026
Merged

NAS-140878 / 26.0.0-RC.1 / Extend error message for full ZFS replication when there are missing datasets (by themylogin)#364
yocalebo merged 1 commit into
stable/26from
NAS-140878-26.0.0-RC.1

Conversation

@bugclerk

@bugclerk bugclerk commented Jul 6, 2026

Copy link
Copy Markdown

Full ZFS replication fails when some of the source datasets with older snapshots are not present on the destination side.

This can happen in case of dataset rename. We do dataset renames when migrating from incus to new containers system, that's the root cause of the reported issue.

I am reluctant to try to replicate dataset renames automatically. We can try parsing zpool history, but, after all, it's just a text stream without any structure and there is no guarantee it is consistent with the real history.

Additionally, we can try matching renamed datasets by snapshots guids (snapshots guid are the same on the source and destination system). However, this will require retrieving a lot of snapshot metadata on both source and destination systems, and add unnecessary complexity for such a rare case.

Original PR: #359

@bugclerk

bugclerk commented Jul 6, 2026

Copy link
Copy Markdown
Author

@yocalebo yocalebo merged commit 0c5a5cb into stable/26 Jul 6, 2026
@yocalebo yocalebo deleted the NAS-140878-26.0.0-RC.1 branch July 6, 2026 12:08
@bugclerk

bugclerk commented Jul 6, 2026

Copy link
Copy Markdown
Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants