Skip to content

Add class to configure generating certificates#449

Merged
ehelms merged 2 commits into
theforeman:masterfrom
ehelms:add-generate
Aug 19, 2025
Merged

Add class to configure generating certificates#449
ehelms merged 2 commits into
theforeman:masterfrom
ehelms:add-generate

Conversation

@ehelms

@ehelms ehelms commented Apr 30, 2024

Copy link
Copy Markdown
Member

The intent of this class is to allow generating any number of the sets of certificates from this module in a simple way. This is also a way to work around the fact that parsing params by Kafo doesn't cleanly work on classes such as certs::apache (see #424).

@ehelms

ehelms commented Apr 30, 2024

Copy link
Copy Markdown
Member Author

See theforeman/foreman-installer#935 for example of how this is intended to be used.

@ekohl ekohl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see this before, but I recall a long time ago that I already discussed something like this with @timogoebel. Then we talked about making it a define so you could easily declare it for multiple hosts.

In effect this is a more configurable version of certs::foreman_proxy_content.

We could even go a step further and generalize it to make certs_tar an optional parameter.

Comment thread manifests/generate.pp Outdated
Comment thread spec/classes/certs_generate_spec.rb Outdated
Comment thread spec/classes/certs_generate_spec.rb
@ehelms

ehelms commented Mar 13, 2025

Copy link
Copy Markdown
Member Author

@evgeni What do you think about merging this in to then proceed with the certs command in the installer?

@evgeni

evgeni commented Aug 19, 2025

Copy link
Copy Markdown
Member

@evgeni What do you think about merging this in to then proceed with the certs command in the installer?

yes please

@ehelms

ehelms commented Aug 19, 2025

Copy link
Copy Markdown
Member Author

@evgeni What do you think about merging this in to then proceed with the certs command in the installer?

yes please

Smash that review button.

@evgeni

evgeni commented Aug 19, 2025

Copy link
Copy Markdown
Member
image

@ehelms ehelms merged commit 81878c1 into theforeman:master Aug 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants