Skip to content

Add certs command#935

Open
ehelms wants to merge 2 commits into
theforeman:developfrom
ehelms:certs-command
Open

Add certs command#935
ehelms wants to merge 2 commits into
theforeman:developfrom
ehelms:certs-command

Conversation

@ehelms

@ehelms ehelms commented Apr 30, 2024

Copy link
Copy Markdown
Member

The idea here is to introduce a command that can stand-alone generate certificates as is done within the installer using the same logic of puppet-certs module. This intentionally does not cover deployment, it simply allows generation of the certificates. This relies upon theforeman/puppet-certs#449 as it introduces a class that makes this process works and avoids the complication that the individual certificate classes create via their params.

The full design idea is to split generation from deployment and allow generation to happen prior to full puppet apply within the installer and allow the installer part to only handle deployment. This will put us a step closer to allowing users to provider their own certificates by standardizing on the set of certificates as inputs where those inputs can come directly from the user or from the self-generated set.

Comment thread foreman_certs/config/foreman-certs-answers.yaml Outdated
Comment thread bin/foreman-certs Outdated
@ehelms ehelms force-pushed the certs-command branch 3 times, most recently from cd4e29a to 29d2d21 Compare March 11, 2025 18:20
@ehelms

ehelms commented Mar 11, 2025

Copy link
Copy Markdown
Member Author

@evgeni I updated this with updates from #1016

@ehelms

ehelms commented Mar 11, 2025

Copy link
Copy Markdown
Member Author

This requires theforeman/puppet-certs#449 and will remain in draft until it's merged.

@ehelms ehelms force-pushed the certs-command branch 2 times, most recently from 1609d58 to feec588 Compare May 6, 2025 18:05
@evgeni evgeni force-pushed the certs-command branch 2 times, most recently from c0e12a9 to 05a0bb3 Compare July 7, 2025 08:43
@evgeni

evgeni commented Aug 19, 2025

Copy link
Copy Markdown
Member

/packit build

@evgeni evgeni force-pushed the certs-command branch 2 times, most recently from 271e39c to d49b954 Compare November 14, 2025 13:33
@ehelms ehelms force-pushed the certs-command branch 2 times, most recently from 58364d5 to 17a0996 Compare February 3, 2026 16:50
@pablomh

pablomh commented Mar 14, 2026

Copy link
Copy Markdown

It seems that theforeman/puppet-certs#449 has been already merged for a while.

I've discovered this because while trying to test foremanctl, I've hit:

TASK [foreman_installer_certs : Enable foreman-installer PR 935 Copr repo] *****
Error: : Task failed: Module failed: Chroot rhel-9-x86_64 does not exist in packit/theforeman-foreman-installer-935

@arvind4501

Copy link
Copy Markdown

/packit build

@packit-as-a-service

Copy link
Copy Markdown

Account arvind4501 has no write access nor is author of PR!

@evgeni

evgeni commented May 15, 2026

Copy link
Copy Markdown
Member

this needed a rebase to get the updated version after branching, which I just did

@evgeni

evgeni commented May 18, 2026

Copy link
Copy Markdown
Member

/packit build

Signed-off-by: Eric D. Helms <ericdhelms@gmail.com>
@ehelms ehelms marked this pull request as ready for review June 10, 2026 14:52
@ehelms

ehelms commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

@evgeni at this point, do you think we should just merge this?

@evgeni

evgeni commented Jun 10, 2026

Copy link
Copy Markdown
Member

Do/will we need this, outside of CI?

@ehelms

ehelms commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

Originally I had some ideas for this use case, but this is largely for CI purposes and testing of migration from foreman-installer to foremanctl. With the change in design in theforeman/foremanctl#421 we could move to a full foreman-installer run instead of fixtures and partial generation of the certificates.

@evgeni

evgeni commented Jun 10, 2026

Copy link
Copy Markdown
Member

I'm not opposed in merging this, but we should see that we don't ship it as part of the regular installer package to not confuse (end) users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants