Fixes #39443 - replace AuditsPageActions tests with RTL testing and fix bug with audits initialization

test/integration/host_js_test.rb

@@ -123,7 +123,10 @@ class HostJSTest < IntegrationTestWithJavascript
     test "all audit redirect to audit page" do
       visit host_details_page_path(@host)
       find('a', :text => /All audits/).click
-      assert_current_path audits_path(search: "host=#{@host.fqdn}")
+      assert_current_path audits_path, ignore_query: true
+      query = Rack::Utils.parse_query(URI.parse(current_url).query)
+      assert_equal "host=#{@host.fqdn}", query['search']
+      assert_equal '1', query['page']
     end
 
     test "manage host statuses modal" do

test/integration/hostgroup_js_test.rb

@@ -21,6 +21,7 @@ class HostgroupJSTest < IntegrationTestWithJavascript
     select2 os.media.first.name, :from => 'hostgroup_medium_id'
     wait_for_ajax
     select2 os.ptables.first.name, :from => 'hostgroup_ptable_id'
+    wait_for_ajax
     fill_in 'hostgroup_root_pass', :with => '12345678'
     click_button 'Submit'
     hostgroup = wait_for do

webpack/assets/javascripts/react_app/routes/Audits/AuditsPage/AuditsPageActions.js

@@ -23,7 +23,8 @@ import { translate as __ } from '../../../common/I18n';
 export const initializeAudits = () => dispatch => {
   const params = getParams();
   dispatch(fetchAudits(params));
-  if (!history.action === 'POP') {
+
+  if (history.action !== 'POP') {
     history.replace({
       pathname: AUDITS_PATH,
       search: stringifyParams(params),
@@ -36,14 +37,17 @@ export const fetchAudits = (
   url = AUDITS_PATH
 ) => async (dispatch, getState) => {
   dispatch({ type: AUDITS_PAGE_SHOW_LOADING });
-  if (selectAuditsHasError(getState()))
+
+  if (selectAuditsHasError(getState())) {
     dispatch({
       type: AUDITS_PAGE_CLEAR_ERROR,
     });
+  }
 
   const onRequestSuccess = ({ data: { audits, itemCount } }) => {
-    if (selectAuditsIsLoadingPage(getState()))
+    if (selectAuditsIsLoadingPage(getState())) {
       dispatch({ type: AUDITS_PAGE_HIDE_LOADING });
+    }
 
     dispatch({
       type: AUDITS_PAGE_UPDATE_QUERY,
@@ -63,9 +67,11 @@ export const fetchAudits = (
       },
     });
   };
+
   const onRequestFail = error => {
-    if (selectAuditsIsLoadingPage(getState()))
+    if (selectAuditsIsLoadingPage(getState())) {
       dispatch({ type: AUDITS_PAGE_HIDE_LOADING });
+    }
 
     dispatch({
       type: AUDITS_PAGE_DATA_FAILED,
@@ -77,6 +83,7 @@ export const fetchAudits = (
       },
     });
   };
+
   try {
     const response = await API.get(
       url,
@@ -87,6 +94,7 @@ export const fetchAudits = (
         search: searchQuery,
       }
     );
+
     return onRequestSuccess(response);
   } catch (error) {
     return onRequestFail(error);