Fixes #39443 - replace AuditsPageActions tests with RTL testing and fix bug with audits initialization#11035
Merged
Lukshio merged 1 commit intoJul 1, 2026
Conversation
andreilakatos
force-pushed
the
fixes-39443-audits-page-actions
branch
from
b9c43f9 to
f6b54ed
Compare
Contributor
Author
|
On this PR I noticed an if statement that would not run ever: |
Lukshio
requested changes
Jun 30, 2026
Lukshio
left a comment
Lukshio
left a comment
Contributor
There was a problem hiding this comment.
Some changes below, also update PR title if you want to update .rb tests in this PR or open following new one.
|
|
||
| test 'creates a hostgroup with provisioning data' do | ||
| os = FactoryBot.create(:ubuntu14_10, :with_associations) | ||
| os = as_admin { FactoryBot.create(:ubuntu14_10, :with_associations) } |
Contributor
There was a problem hiding this comment.
Is there a reason to test it as_admin?
Contributor
Author
There was a problem hiding this comment.
That's what cursor helped me for the integration test to pass. I'll try to remove to see if it works.
andreilakatos
changed the title
Contributor
|
@andreilakatos Looks good, squash please |
andreilakatos
force-pushed
the
fixes-39443-audits-page-actions
branch
from
8bb63e5 to
1526e68
Compare
Lukshio
approved these changes
Jul 1, 2026
Contributor
|
CI failure not related, thanks @andreilakatos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39443 - replace AuditsPageActions tests with RTL testing