Skip to content

🔒 Fix unbounded string split in default Parse (v2) #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tetri wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🔒 Fix unbounded string split in default Parse (v2) #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/CalendarVersioning/CalendarVersion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,17 @@ public static CalendarVersion Parse(string input, CalendarVersionFormat? format
if (string.IsNullOrWhiteSpace(input))
throw new ArgumentException("Input cannot be null or empty", nameof(input));

if (input.Length > 256)
throw new ArgumentException("Input version string is too long", nameof(input));

int year = 0, month = 0;
int? day = null, minor = null;

var parts = input.Split('.');
string[] parts;
if (format == null)
{
parts = input.Split('.', 5);

// Default parsing: YYYY.MM[.DD[.Minor]]
if (parts.Length is < 2 or > 4)
throw new FormatException($"Version string '{input}' does not match default format 'YYYY.MM[.DD[.Minor]]'");
Expand All @@ -51,7 +55,9 @@ public static CalendarVersion Parse(string input, CalendarVersionFormat? format

// Parsing using the format
string pattern = format.Pattern;
var tokens = pattern.Split('.');
var tokens = pattern.Split('.', 10);
parts = input.Split('.', tokens.Length + 1);

if (tokens.Length != parts.Length)
throw new FormatException($"Version string '{input}' does not match format '{pattern}'");

Expand Down
22 changes: 22 additions & 0 deletions tests/CalendarVersioning.Tests/UnitTests/ParsingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,5 +103,27 @@ public void Parse_CustomFormat_InvalidYY_ShouldThrowFormatException()
var format = new CalendarVersionFormat("YY.MM");
Assert.Throws<FormatException>(() => CalendarVersion.Parse("123.04", format));
}

[Fact]
public void Parse_TooLongInput_ShouldThrowArgumentException()
{
string longInput = new string('a', 257);
Assert.Throws<ArgumentException>(() => CalendarVersion.Parse(longInput));
}

[Fact]
public void Parse_TooManyDots_ShouldThrowFormatException()
{
string inputWithManyDots = "2025.04.01.1.extra.dots"; // 6 parts
Assert.Throws<FormatException>(() => CalendarVersion.Parse(inputWithManyDots));
}

[Fact]
public void Parse_CustomFormat_TooManyDots_ShouldThrowFormatException()
{
var format = new CalendarVersionFormat("YYYY.MM");
string inputWithManyDots = "2025.04.01"; // 3 parts for 2 tokens
Assert.Throws<FormatException>(() => CalendarVersion.Parse(inputWithManyDots, format));
}
}
}
Loading