🔒 Fix unbounded string split in default Parse (v2)#33
Conversation
- Added input length check (max 256 chars) to prevent excessive memory allocation.
- Updated default parsing to use bounded Split('.', 5).
- Updated custom format parsing to use bounded Split based on token count.
- Bounded token split for format pattern.
- Resolved CS0136 variable naming conflict from previous attempt.
- Added security test cases for long inputs and excessive delimiters.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: This PR fixes a security vulnerability where
CalendarVersion.Parseused an unboundedstring.Spliton user-provided input.Splitmethod to allocate a massive array and many small strings, leading to a Denial of Service (DoS) due to excessive memory consumption and CPU usage.🛡️ Solution:
Splitoperation to a maximum number of parts (5 for default format, ortokenCount + 1for custom formats).partsvariable once to avoid CS0136 errors.PR created automatically by Jules for task 1080110722513811361 started by @tetri