chore!: do not wait for all the exposed ports to be ready#3199
Merged
mdelapenya merged 2 commits intoJun 4, 2025
Conversation
It leads to flakiness for the following: 1. it defined a non-configurable timeout of 5s, which could not be enough depending on the underlying hardware. 2. we strongly recommend users to add a consistent wait strategy, and the library must provide robust building blocks to perform that. The wait strategies allow users to properly define the readiness checks, so the core just should honour that.
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Jun 10, 2025
* main: fix: use PortEndpoint() in a few more modules (testcontainers#3203) fix: try to fix more IPv6 handling issues (testcontainers#3198) chore!: do not wait for all the exposed ports to be ready (testcontainers#3199)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is removing the readiness check for the exposed ports, because
It leads to flakiness for the following:
Why is it important?
Reduces flakiness for a condition that should be defined from the user side.
Related issues