fix: try to fix more IPv6 handling issues#3198
Conversation
Avoid allocating an unbounded buffer only to throw it away immediately.
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ash2k
changed the title
This only fixes some of the modules (ran out of time).
|
@ash2k thanks for your contribution, indeed, I've been thinking about this to simplify all the modules, but you took the lead! thanks for making it possible. There is an ongoing PR to remove the readinessCheck for the mapped ports, which is causing flakiness more and more, so let me postpone the merge of this PR until that (I'm on it now). Now that you showcased the new pattern for getting the host ports in this PR, my suggestion after this is merged would be to send smaller chunks for the rest of the modules, 1-2 per PR, so that it's easier for the CI to pass, and for us to review. WDYT? |
|
@mdelapenya Makes sense, thank you! I'll send smaller PRs next time :) Regarding the test failures - I think it's a legit failure but I'm not sure how to debug it further. I can reproduce it locally but I have not idea why this might be happening and how to get more information about what is going on. Ideas? |
|
I think we need to merge #3199 to rebase this PR and see the flakiness removed |
|
ack. I'll rebase once it's merged. |
|
@mdelapenya Do you want me to rebase or do you intend to merge it as-is? |
No, it's fine as is 👏 Let's work in follow-up PRs for the rest of the modules 🙏 |
|
Thank you! I'll try to get some time to fix the remaining modules soon. |
|
Nice work on this @ash2k |
* main: fix: use PortEndpoint() in a few more modules (testcontainers#3203) fix: try to fix more IPv6 handling issues (testcontainers#3198) chore!: do not wait for all the exposed ports to be ready (testcontainers#3199)
* feat(nebulagraph): add NebulaGraph module * Resolve comments 1 * Update document * Remove static container name * Resolve comments 2 * docs: refine * docs: add nebulagraph to mkdocs nav entry * chore: fix lint (auto) * chore: append errors to the same slice * chore: handle state error * chore: format errors * chore: do not hide container package * chore: handle IPv6 See #3198 * chore: simplify * fix: remove activator on error * Fix tests 1 * Fix tests 2 --------- Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
3 participants
What does this PR do?
See individual commits.
Why is it important?
Docker seem to prefer IPv6 and I'm still having various issues that seem to be caused by port mapping with IPv6 on the host/container.
Related issues