Skip to content
This repository was archived by the owner on Mar 16, 2025. It is now read-only.

Migration to the latest flutter_web_auth_2 - #197

Open
dmk-rib wants to merge 2 commits into
teranetsrl:masterfrom
dmk-rib:master
Open

Migration to the latest flutter_web_auth_2#197
dmk-rib wants to merge 2 commits into
teranetsrl:masterfrom
dmk-rib:master

Conversation

@dmk-rib

@dmk-rib dmk-rib commented Jul 22, 2024

Copy link
Copy Markdown

No description provided.

@robertdewilde-dev

Copy link
Copy Markdown

Can we please get this merged? It's a blocker for newer builds

@robertdewilde-dev

robertdewilde-dev commented Feb 17, 2025

Copy link
Copy Markdown

A hacky temp workaround to get things compiling is to put this in pubspec.yaml:

dependency_overrides:
  flutter_web_auth_2: ^4.1.0

Source https://www.appwrite.io/threads/1334415894394306571

@ThexXTURBOXx

Copy link
Copy Markdown
Contributor

A hacky temp workaround to get things compiling is to put this in pubspec.yaml:

That's not a good workaround as it has breaking changes.
I would also recommend my PR here (#178) instead of this one as it makes all the options of flutter_web_auth_2 customisable and updates all dependencies accordingly.
The "real" workaround is the following:

dependency_overrides:
  oauth2_client:
    git:
      url: https://github.com/ThexXTURBOXx/oauth2_client.git

@ThexXTURBOXx ThexXTURBOXx mentioned this pull request Feb 28, 2025
@robertdewilde-dev

Copy link
Copy Markdown

Only if you fork it yourself and do the changes.

I would not depend on untrusted (no offense 😜) 3rd party repo for this.

But that's why it says both "hacky", "temp" and "workaround" 😅

Either way this MR should get merged.

@ThexXTURBOXx

Copy link
Copy Markdown
Contributor

With this logic, you should probably not be depending on flutter_web_auth_2 at all - since I am the untrusted maintainer of it ;)
But yes, I do understand that depending on 3rd party repos is not good practice. However, it gets more and more common nowadays when more and more repos become unmaintained, alas.
It's just sad to see what pub.dev is becoming like a NPM v2, where every second repo has a million forks and everything gets distributed more and more - without any central place for the "one thing" you need.

At least, I am still of the impression that my PR (#178) offers the same changes, but in a better way than this PR here.

@robertdewilde-dev

Copy link
Copy Markdown

Awesome, didn't notice sorry, nice work, thanks. And thanks for your efforts maintaining it.

@ThexXTURBOXx

ThexXTURBOXx commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

I have reached out to Enrico by email and he agreed to either archive this repo (and the package) and refer to my fork package instead.
The maintenance issues should thus be resolved soon!

@ThexXTURBOXx

Copy link
Copy Markdown
Contributor

I have just released version 4.0.0, which fixes all these issues:
https://pub.dev/packages/oauth2_client

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants